model_name(als) trains out unexist movieIds #59

capricorn9527 · 2017-10-26T07:19:13Z

I copied the content of example file "movielens.py" into my program file "datatrain.py" , trained the ml-20m dataset with model(als).
some unexist movieIds were trained out. how is that happened??

Traceback (most recent call last):
File "datatrain.py", line 108, in
min_rating=args.min_rating)
File "datatrain.py", line 86, in calculate_similar_movies
o.write("%s\t%s\t%s\n" % (movie, movie_lookup[other], score))
KeyError: 113812

There used to be problems with the movielens example, where occasionally items with no users would be returned. Since these items sometimes had no matching label, this would trip up the code looking up the string to show (#59) Fix this by detecting this case, and setting the factors to 0. When returning similar items also make sure that we don't introduce NaN values here.

benfred · 2017-11-01T19:43:24Z

Thanks for pointing this out! There were some bugs related to handling of movies with no users (which the movie lens set has after filtering down to only positive reviews). I've fixed in that last PR, should work well now.

benfred mentioned this issue Nov 1, 2017

Fixes for having no data on a user/item #61

Merged

benfred closed this as completed Nov 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

model_name(als) trains out unexist movieIds #59

model_name(als) trains out unexist movieIds #59

capricorn9527 commented Oct 26, 2017

benfred commented Nov 1, 2017

model_name(als) trains out unexist movieIds #59

model_name(als) trains out unexist movieIds #59

Comments

capricorn9527 commented Oct 26, 2017

I copied the content of example file "movielens.py" into my program file "datatrain.py" , trained the ml-20m dataset with model(als). some unexist movieIds were trained out. how is that happened??

Traceback (most recent call last): File "datatrain.py", line 108, in min_rating=args.min_rating) File "datatrain.py", line 86, in calculate_similar_movies o.write("%s\t%s\t%s\n" % (movie, movie_lookup[other], score)) KeyError: 113812

benfred commented Nov 1, 2017

I copied the content of example file "movielens.py" into my program file "datatrain.py" , trained the ml-20m dataset with model(als).
some unexist movieIds were trained out. how is that happened??

Traceback (most recent call last):
File "datatrain.py", line 108, in
min_rating=args.min_rating)
File "datatrain.py", line 86, in calculate_similar_movies
o.write("%s\t%s\t%s\n" % (movie, movie_lookup[other], score))
KeyError: 113812