Scale diagram #17
Merged
Scale diagram #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! - this looks like it also fixes issue #7 , and does so in a much better way than I was thinking Just to verify though, it was only the labels on the diagram getting clipped right? otherwise there might be a bug in the 'venn.scaleSolution' call |
|
I believe that it was only the labels. I cannot say for sure, since I had the code (center diagram) in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the generated diagram is larger than the bounds of the SVG. This fix applies a scale to ensure that the generated diagram is within bounds and then applies the centering (center_diagram branch).