Optionally propagate exceptions during message sending #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't realize that would fail on 2.7. I'll update shortly |
benhoyt
requested changes
Sep 24, 2021
benhoyt
reviewed
Sep 24, 2021
|
@benhoyt Thanks for the feedback! Just pushed the changes. Not sure if I need to mark the requested changes resolved or not. First time doing a RP in someone's repo. |
benhoyt
requested changes
Sep 24, 2021
| @@ -42,6 +42,7 @@ def __init__(self, host, port=2003, prefix=None, timeout=5, interval=None, | |||
| Use "tags" to specify common or default tags for this Sender, which | |||
| are sent with each metric along with any tags passed to send(). | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Don't worry for now, but it's best to avoid extraneous formatting in other repos, unless you're changing it to match the existing style in that repo. People have different styles and it just adds noise to the PR (and potential for bikeshedding).
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option added to raise exceptions during message sending.