Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastlane changelogs are too long #6

Closed
IzzySoft opened this issue Mar 17, 2023 · 5 comments
Closed

Fastlane changelogs are too long #6

IzzySoft opened this issue Mar 17, 2023 · 5 comments

Comments

@IzzySoft
Copy link

Per specification, they are limited each to 500 char. The last two exceed this limit and hence are truncated, mid-sentence.
@benibela
Copy link
Owner

Not just the last two. I make a lot of changes


$   l -S de/changelogs/
total 668
-rw-rw-r-- 1 benito benito 5137 Jan 12 13:49 1500.txt
-rw-rw-r-- 1 benito benito 2937 Jan 12 13:49 2050.txt
-rw-rw-r-- 1 benito benito 2235 Jan 12 13:49 1510.txt
-rw-rw-r-- 1 benito benito 2204 Jan 12 13:49 2056.txt
-rw-rw-r-- 1 benito benito 1473 Jan 12 13:49 1930.txt
-rw-rw-r-- 1 benito benito 1401 Jan 12 13:49 1980.txt
-rw-rw-r-- 1 benito benito 1399 Jan 12 13:49 2025.txt
-rw-rw-r-- 1 benito benito 1346 Jan 12 13:49 1900.txt
-rw-rw-r-- 1 benito benito 1338 Jan 12 13:49 1975.txt
-rw-rw-r-- 1 benito benito 1264 Jan 12 13:49 1885.txt
-rw-rw-r-- 1 benito benito 1215 Jan 12 13:49 1600.txt
-rw-rw-r-- 1 benito benito 1150 Jan 12 13:49 2010.txt
-rw-rw-r-- 1 benito benito 1147 Jan 12 13:49 1650.txt
-rw-rw-r-- 1 benito benito 1080 Jan 12 13:49 2000.txt
-rw-rw-r-- 1 benito benito 1075 Jan 12 13:49 1700.txt
-rw-rw-r-- 1 benito benito 1011 Jan 12 13:49 2580.txt
-rw-rw-r-- 1 benito benito 1003 Jan 12 13:49 1870.txt
-rw-rw-r-- 1 benito benito 1000 Jan 12 13:49 1690.txt
-rw-rw-r-- 1 benito benito  992 Jan 12 13:49 1985.txt
-rw-rw-r-- 1 benito benito  955 Jan 12 13:49 1880.txt
-rw-rw-r-- 1 benito benito  914 Jan 12 13:49 1400.txt
-rw-rw-r-- 1 benito benito  897 Jan 12 13:49 1950.txt
-rw-rw-r-- 1 benito benito  894 Jan 12 13:49 1887.txt
-rw-rw-r-- 1 benito benito  872 Jan 12 13:49 1850.txt
-rw-rw-r-- 1 benito benito  868 Jan 12 13:49 1963.txt
-rw-rw-r-- 1 benito benito  866 Jan 12 13:49 2160.txt
-rw-rw-r-- 1 benito benito  845 Jan 12 13:49 1990.txt
-rw-rw-r-- 1 benito benito  811 Jan 12 13:49 1865.txt
-rw-rw-r-- 1 benito benito  794 Jan 12 13:49 1970.txt
-rw-rw-r-- 1 benito benito  776 Jan 12 13:49 1680.txt
-rw-rw-r-- 1 benito benito  765 Jan 12 13:49 1805.txt
-rw-rw-r-- 1 benito benito  756 Jan 12 13:49 2166.txt
-rw-rw-r-- 1 benito benito  739 Jan 12 13:49 2200.txt
-rw-rw-r-- 1 benito benito  722 Jan 12 13:49 1996.txt
-rw-rw-r-- 1 benito benito  721 Jan 12 13:49 2300.txt
-rw-rw-r-- 1 benito benito  717 Jan 12 13:49 1993.txt
-rw-rw-r-- 1 benito benito  704 Jan 12 13:49 2150.txt
-rw-rw-r-- 1 benito benito  691 Jan 12 13:49 0905.txt
-rw-rw-r-- 1 benito benito  686 Jan 12 13:49 0980.txt
-rw-rw-r-- 1 benito benito  672 Jan 12 13:49 1800.txt
-rw-rw-r-- 1 benito benito  672 Jan 12 13:49 2400.txt
-rw-rw-r-- 1 benito benito  670 Jan 12 13:49 1200.txt
-rw-rw-r-- 1 benito benito  668 Jan 12 13:49 1953.txt
-rw-rw-r-- 1 benito benito  660 Jan 12 13:49 2042.txt
-rw-rw-r-- 1 benito benito  641 Jan 12 13:49 1666.txt
-rw-rw-r-- 1 benito benito  640 Jan 12 13:49 1515.txt
-rw-rw-r-- 1 benito benito  638 Jan 12 13:49 1910.txt
-rw-rw-r-- 1 benito benito  620 Jan 12 13:49 2620.txt
-rw-rw-r-- 1 benito benito  613 Jan 12 13:49 1998.txt
-rw-rw-r-- 1 benito benito  607 Jan 12 13:49 1675.txt
-rw-rw-r-- 1 benito benito  592 Jan 12 13:49 2052.txt
-rw-rw-r-- 1 benito benito  590 Jan 12 13:49 1670.txt
-rw-rw-r-- 1 benito benito  590 Feb 19 14:35 2650.txt
-rw-rw-r-- 1 benito benito  590 Feb 19 15:21 2651.txt
-rw-rw-r-- 1 benito benito  588 Jan 12 13:49 2030.txt
-rw-rw-r-- 1 benito benito  569 Jan 12 13:49 1655.txt
-rw-rw-r-- 1 benito benito  560 Jan 12 13:49 1710.txt
-rw-rw-r-- 1 benito benito  554 Jan 12 13:49 0990.txt
-rw-rw-r-- 1 benito benito  547 Jan 12 13:49 2410.txt
-rw-rw-r-- 1 benito benito  546 Jan 12 13:49 2100.txt
-rw-rw-r-- 1 benito benito  539 Jan 12 13:49 2130.txt
-rw-rw-r-- 1 benito benito  527 Jan 12 13:49 1830.txt
-rw-rw-r-- 1 benito benito  527 Jan 12 13:49 2040.txt
-rw-rw-r-- 1 benito benito  526 Jan 12 13:49 1965.txt
-rw-rw-r-- 1 benito benito  526 Jan 12 13:49 2046.txt
-rw-rw-r-- 1 benito benito  508 Jan 12 13:49 2552.txt
-rw-rw-r-- 1 benito benito  507 Jan 12 13:49 1860.txt
-rw-rw-r-- 1 benito benito  503 Jan 12 13:49 1852.txt
-rw-rw-r-- 1 benito benito  503 Jan 12 13:49 1994.txt
-rw-rw-r-- 1 benito benito  481 Jan 12 13:49 2510.txt
-rw-rw-r-- 1 benito benito  469 Jan 12 13:49 1615.txt
-rw-rw-r-- 1 benito benito  434 Jan 12 13:49 1960.txt
-rw-rw-r-- 1 benito benito  429 Jan 12 13:49 1300.txt
-rw-rw-r-- 1 benito benito  423 Jan 12 13:49 0987.txt
-rw-rw-r-- 1 benito benito  420 Jan 12 13:49 2415.txt
-rw-rw-r-- 1 benito benito  418 Jan 12 13:49 1810.txt
-rw-rw-r-- 1 benito benito  418 Jan 12 13:49 2174.txt
-rw-rw-r-- 1 benito benito  412 Jan 12 13:49 1301.txt
-rw-rw-r-- 1 benito benito  406 Jan 12 13:49 1987.txt
-rw-rw-r-- 1 benito benito  402 Jan 12 13:49 2064.txt
-rw-rw-r-- 1 benito benito  401 Jan 12 13:49 1972.txt
-rw-rw-r-- 1 benito benito  398 Jan 12 13:49 2168.txt
-rw-rw-r-- 1 benito benito  389 Jan 12 13:49 1000.txt
-rw-rw-r-- 1 benito benito  383 Jan 12 13:49 1905.txt
-rw-rw-r-- 1 benito benito  381 Jan 12 13:49 2610.txt
-rw-rw-r-- 1 benito benito  378 Jan 12 13:49 1835.txt
-rw-rw-r-- 1 benito benito  374 Jan 12 13:49 2120.txt
-rw-rw-r-- 1 benito benito  360 Jan 12 13:49 0999.txt
-rw-rw-r-- 1 benito benito  357 Jan 12 13:49 1873.txt
-rw-rw-r-- 1 benito benito  353 Jan 12 13:49 1991.txt
-rw-rw-r-- 1 benito benito  346 Jan 12 13:49 1250.txt
-rw-rw-r-- 1 benito benito  346 Jan 12 13:49 1610.txt
-rw-rw-r-- 1 benito benito  340 Jan 12 13:49 2600.txt
-rw-rw-r-- 1 benito benito  339 Jan 12 13:49 1820.txt
-rw-rw-r-- 1 benito benito  339 Jan 12 13:49 2220.txt
-rw-rw-r-- 1 benito benito  336 Jan 12 13:49 1932.txt
-rw-rw-r-- 1 benito benito  333 Jan 12 13:49 2590.txt
-rw-rw-r-- 1 benito benito  330 Jan 12 13:49 2031.txt
-rw-rw-r-- 1 benito benito  324 Jan 12 13:49 1620.txt
-rw-rw-r-- 1 benito benito  318 Jan 12 13:49 2302.txt
-rw-rw-r-- 1 benito benito  317 Jan 12 13:49 1845.txt
-rw-rw-r-- 1 benito benito  317 Jan 12 13:49 2182.txt
-rw-rw-r-- 1 benito benito  303 Jan 12 13:49 1995.txt
-rw-rw-r-- 1 benito benito  303 Jan 12 13:49 2172.txt
-rw-rw-r-- 1 benito benito  297 Jan 12 13:49 2543.txt
-rw-rw-r-- 1 benito benito  289 Jan 12 13:49 1840.txt
-rw-rw-r-- 1 benito benito  287 Jan 12 13:49 2194.txt
-rw-rw-r-- 1 benito benito  285 Jan 12 13:49 0991.txt
-rw-rw-r-- 1 benito benito  283 Jan 12 13:49 1100.txt
-rw-rw-r-- 1 benito benito  282 Jan 12 13:49 2540.txt
-rw-rw-r-- 1 benito benito  279 Jan 12 13:49 2630.txt
-rw-rw-r-- 1 benito benito  277 Jan 12 13:49 1119.txt
-rw-rw-r-- 1 benito benito  271 Jan 12 13:49 0950.txt
-rw-rw-r-- 1 benito benito  270 Jan 12 13:49 2134.txt
-rw-rw-r-- 1 benito benito  264 Jan 12 13:49 1658.txt
-rw-rw-r-- 1 benito benito  259 Jan 12 13:49 2164.txt
-rw-rw-r-- 1 benito benito  258 Jan 12 13:49 0997.txt
-rw-rw-r-- 1 benito benito  253 Jan 12 13:49 2140.txt
-rw-rw-r-- 1 benito benito  252 Jan 12 13:49 1999.txt
-rw-rw-r-- 1 benito benito  249 Jan 12 13:49 2520.txt
-rw-rw-r-- 1 benito benito  248 Jan 12 13:49 1955.txt
-rw-rw-r-- 1 benito benito  245 Jan 12 13:49 0985.txt
-rw-rw-r-- 1 benito benito  245 Jan 12 13:49 2048.txt
-rw-rw-r-- 1 benito benito  240 Jan 12 13:49 1117.txt
-rw-rw-r-- 1 benito benito  232 Jan 12 13:49 0993.txt
-rw-rw-r-- 1 benito benito  226 Jan 12 13:49 1935.txt
-rw-rw-r-- 1 benito benito  224 Jan 12 13:49 2044.txt
-rw-rw-r-- 1 benito benito  221 Jan 12 13:49 1967.txt
-rw-rw-r-- 1 benito benito  215 Jan 12 13:49 1841.txt
-rw-rw-r-- 1 benito benito  206 Jan 12 13:49 2190.txt
-rw-rw-r-- 1 benito benito  205 Jan 12 13:49 0902.txt
-rw-rw-r-- 1 benito benito  205 Jan 12 13:49 2070.txt
-rw-rw-r-- 1 benito benito  195 Jan 12 13:49 2592.txt
-rw-rw-r-- 1 benito benito  193 Jan 12 13:49 1659.txt
-rw-rw-r-- 1 benito benito  186 Jan 12 13:49 2500.txt
-rw-rw-r-- 1 benito benito  182 Jan 12 13:49 0988.txt
-rw-rw-r-- 1 benito benito  180 Jan 12 13:49 1660.txt
-rw-rw-r-- 1 benito benito  176 Jan 12 13:49 2225.txt
-rw-rw-r-- 1 benito benito  176 Jan 12 13:49 2570.txt
-rw-rw-r-- 1 benito benito  173 Jan 12 13:49 1847.txt
-rw-rw-r-- 1 benito benito  170 Jan 12 13:49 1938.txt
-rw-rw-r-- 1 benito benito  164 Jan 12 13:49 2180.txt
-rw-rw-r-- 1 benito benito  160 Jan 12 13:49 2230.txt
-rw-rw-r-- 1 benito benito  155 Jan 12 13:49 2122.txt
-rw-rw-r-- 1 benito benito  153 Jan 12 13:49 2127.txt
-rw-rw-r-- 1 benito benito  142 Jan 12 13:49 0992.txt
-rw-rw-r-- 1 benito benito  135 Jan 12 13:49 1115.txt
-rw-rw-r-- 1 benito benito  128 Jan 12 13:49 2110.txt
-rw-rw-r-- 1 benito benito  108 Jan 12 13:49 0906.txt
-rw-rw-r-- 1 benito benito  106 Jan 12 13:49 2125.txt
-rw-rw-r-- 1 benito benito  103 Jan 12 13:49 1657.txt
-rw-rw-r-- 1 benito benito  100 Jan 12 13:49 2222.txt
-rw-rw-r-- 1 benito benito   97 Jan 12 13:49 0994.txt
-rw-rw-r-- 1 benito benito   95 Jan 12 13:49 0989.txt
-rw-rw-r-- 1 benito benito   87 Jan 12 13:49 0995.txt
-rw-rw-r-- 1 benito benito   81 Jan 12 13:49 2632.txt
-rw-rw-r-- 1 benito benito   75 Jan 12 13:49 2185.txt
-rw-rw-r-- 1 benito benito   69 Jan 12 13:49 1402.txt
-rw-rw-r-- 1 benito benito   67 Jan 12 13:49 1836.txt
-rw-rw-r-- 1 benito benito   56 Jan 12 13:49 2192.txt
-rw-rw-r-- 1 benito benito   53 Jan 12 13:49 1866.txt
-rw-rw-r-- 1 benito benito   51 Jan 12 13:49 1110.txt
-rw-rw-r-- 1 benito benito   49 Jan 12 13:49 2530.txt
-rw-rw-r-- 1 benito benito   42 Jan 12 13:49 2126.txt
-rw-rw-r-- 1 benito benito   35 Jan 12 13:49 2501.txt
-rw-rw-r-- 1 benito benito   34 Jan 12 13:49 0998.txt

I cannot truncate them all

@IzzySoft
Copy link
Author

I just keep max the last 3, so from my side no need to go back further. Most important is to remember it for future releases 😉 Thanks!

@IzzySoft
Copy link
Author

Btw, seems that Github API has a problem if file names contain non-7bit-ASCII characters:

de.benibela.videlibri: Commits neither array nor object for 'fastlane/metadata/android/de/images/phoneScreenshots/android-phone-zählen.png' on spec 'fastlane/metadata/android/de/images/phoneScreenshots' - cannot set ts/date

Maybe you can rename it (e.g. turn the ä into ae, or simply keep the English file name; no need to translate it as noboy reads it anyway 😉)?

@benibela
Copy link
Owner

benibela commented Apr 2, 2023

or simply keep the English file name;

it is the opposite. everything was German first and I translated somethings to English. And there are no English screenshots

no need to translate it as noboy reads it anyway wink)?

you read it

benibela added a commit that referenced this issue Apr 2, 2023
@benibela
ascii only file name (see github #6)
37d9e6a
@IzzySoft
Copy link
Author

IzzySoft commented Apr 2, 2023

And there are no English screenshots

Nevertheless, the Umlaut in the file name seems to cause problems in the Github API. So thanks for renaming that file!

you read it

Only because the error threw it into my face. Why should I bother about the file name of the screenshot as long as it shows up fine? But thanks to the fact it caused an API error, it would never have been updated in my repo, as the API failed to deliver. Luckily solved now, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benibela @IzzySoft