Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss Variables with path and typo3/cms-composer-installers >= 4 #1393

Open
3 tasks done
thomaskieslich opened this issue Jun 26, 2023 · 0 comments
Open
3 tasks done
Labels

Comments

@thomaskieslich
Copy link
Contributor

Bug Report

Prerequisites

  • Can you reproduce the problem on TYPO3 v11.5 LTS
  • Can you reproduce the problem on TYPO3 v12.4 LTS
  • Did you perform a cursory search
    to see if your bug or enhancement is already reported?

Description

From cms-composer-installers >= 4 public assets will be stored in _assets Folder. If you set Paths in scss Variable it didn't work anymore.

$icon-path: "/typ3conf/ext/sitepackage/Resources/Public/Icons";

$icon-path: "EXT:sitepackage/Resources/Public/Icons"; could work if it resolved to the current Path in assets Folder.
I think one of the Points to do this could be the TypoScript CompilerService.

if (strpos($value, 'EXT:') === 0) {
    $publicResourcePath = PathUtility::getPublicResourceWebPath($value);
    $value = PathUtility::getCanonicalPath($publicResourcePath);
}

[A clear and concise description of what the bug is.]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior

[What you expected to happen]

Actual behavior

[What actually happened]

Screenshots

[If applicable, add screenshots to help explain your problem.]

Versions

You can get this information from executing composer show at the command line
if your TYPO3 installation is composer based, otherwise the version number will
be shown in the extension manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant