fix: printer: JSXText: remove trailing whitespaces #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderaiser
force-pushed
the
fix/printer-jsx-text-remove-trailing-whitesaces
branch
2 times, most recently
from
4bff30a
to
c835b17
Compare
coderaiser
force-pushed
the
fix/printer-jsx-text-remove-trailing-whitesaces
branch
from
c835b17
to
bf6a768
Compare
milahu
reviewed
Nov 1, 2022
Comment on lines
+91
to
+94
| ' return (\n' + | ||
| ' <div abc="app">hello {name}\n' + | ||
| ' </div>\n' + | ||
| ' );\n' + |
There was a problem hiding this comment.
thanks for the bugfix
now i just need prettier for pretty jsx
There was a problem hiding this comment.
If you have ideas for a better fix, you are welcome :)
eventualbuddha
added a commit
that referenced
this pull request
Jun 1, 2024
This just re-applies the fix from #1223 by @coderaiser on top of `master`.
eventualbuddha
added a commit
that referenced
this pull request
Jun 1, 2024
This just re-applies the fix from #1223 by @coderaiser on top of `master`.
|
Merged via #1403 and released in v0.23.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #211: trailing whitespaces removed for now reason.
Landed in @putout/recast v1.10.0.