Review TODO/FIXME/etc comments and address some of them #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying entities instead
benjie
commented
Apr 17, 2023
…ctly on all the relevant entities.
…fter the first are now a single config object.
…MapStep`/`map()` are now `RemapKeysStep`/`remapKeys()`. `ListTransform` now accepts `listStep` rather than `listPlan`.
…PgFirstLastBeforeAfterArgsPlugin` (because it applies to lists as well as connections). `PgInsertStep`/`pgInsert()`/`PgUpdateStep`/`pgUpdate()`/`PgDeleteStep`/`pgDelete()` are now `PgInsertSingleStep`/`pgInsertSingle()`/`PgUpdateSingleStep`/`pgUpdateSingle()`/`PgDeleteSingleStep`/`pgDeleteSingle()` (to make space to add a future bulk API if we want to). `config.schema.orderByNullsLast` is now `config.schema.pgOrderByNullsLast` for consistency (V4 preset users are unaffected). Lots of field scopes in `graphile-build-pg` have been updated to incorporate `field` into their names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through every TODO/FIXME/HACK/XXX comment in the code and have addressed the ones that I felt were either straightforward and fast to achieve or needed to be done before we moved to "alpha". Here are some standout changes:
listOfCodecnow accepts only two parameters, the second being a configuration object that contains all the previous remaining argumentsdescriptionno longer exists on theextensions- in most cases it has been elevated to being on the resource/codec/column/unique/relationship/etc itself.__TrackedObjectStepis now__TrackedValueStepMapStepandmap()are nowRemapKeysStepandremapKeys()respectivelyListTransformsteps now accept alistSteprather than alistPlanPgConnectionArgFirstLastBeforeAfterPluginis nowPgFirstLastBeforeAfterArgsPlugin(because it applies to lists as well as connections)pgInsert()/PgInsertStepare nowpgInsertSingle()/PgInsertSingleStep(and same for update/delete) to allow space for a PgInsertStep bulk step to exist in the future.config.schema.orderByNullsLastis nowconfig.schema.pgOrderByNullsLast. V4 preset users are unaffected.