Add complete unit tests for utils interface #5
Conversation
| ]; | ||
| utils.appendChild(jml, fragment); | ||
| assert.deepEqual(fragment, []); | ||
| }); |
There was a problem hiding this comment.
I added this test when I realized the fragment was being muted (by calling child.shift()). I wasn't sure if this was intentional. Personally, I would argue that functions should be pure whenever possible and that the child param should not be mutated.
There was a problem hiding this comment.
Here's what a fix would look like:
https://github.com/pgoldrbx/jsonml.js/compare/test/utils...pgoldrbx:fix/child-fragment-mutation?expand=1
There was a problem hiding this comment.
Yep, we had better to make function pure, and you can fix it in next PR, thanks.
| const child = new function RawChild() {}; | ||
| utils.appendChild(jml, child); | ||
| assert.strictEqual(jml, ['div', child]); | ||
| }); |
There was a problem hiding this comment.
Here is what I believe a fix would be:
https://github.com/pgoldrbx/jsonml.js/compare/test/utils...pgoldrbx:fix/raw-child?expand=1
There was a problem hiding this comment.
Just raise a new issue, I need to to read the source code, and may be re-design these APIs.
| const attrs = { a: 1 }; | ||
| utils.appendChild(jml, attrs); | ||
| assert.deepEqual(jml, ['div', { a: 1 }]); | ||
| }); |
There was a problem hiding this comment.
This also fails but it is due to the error above. The isRaw call happens before the method can reach this logic.
There was a problem hiding this comment.
Just raise a new issue, I need to to read the source code, and may be re-design these APIs.
|
|
||
| utils.appendChild(jml, 'z'); | ||
| assert.deepEqual(jml, ['', 'xz']); | ||
| }); |
There was a problem hiding this comment.
I added this test based on the condition to allow a parent element with no length. I'm not really sure what the purpose is. To build a fragment?
There was a problem hiding this comment.
Just raise a new issue, I need to to read the source code, and may be re-design these APIs.
This PR adds all missing test for the
utilsmethods. I have tried to be strict while adhering to the existing test style as much as possible.NOTE: These tests raise at least one bug and some other outstanding questions.
isRawis called byappendChildbut is not defined.Failing tests are commented and skipped for the moment.