not properly working in windows

[the-eater]

bugs found:

• When scanning it loops infinitely through all the files
• images and MP3's paths are resolved to "C:\C:"

I may have missed some things

[benkaiser]

What do you have the directory set to in your config.js file?

Do you know what could be causing this code-wise, it would be located in the library_functions.js file.
If you manage to figure it out feel free to clone my repo, fix the bug and submit a pull request.

[benkaiser]

It might just need a few path.join calls instead of using / characters. See the documentation here. It is not my highest priority supporting windows as it is not my main platform on any of my devices, I just use it for occasional gaming.

[the-eater]

my dir is C:\Users\corné\SkyDrive\Musica by remove the { root: '/' } thingies I solved around 70% of them. I will try again to fix it >.> (cloned your repo already like 2 times xD)

[benkaiser]

What did you change the { root: '/' } thingies to? submit a pull request and it will all make sense then :)

[the-eater]

I actually just removed them because if your path already starts with '/' linux will just call from the main '/' :)

[the-eater]

the multiple looping error thing not found yet

[benkaiser]

Yeh I found that I needed to include it if the file I was serving was anything higher than the current directory. It was a think express.js did to protect users of your app entering urls of higher directories and hacking you apps, but in this case we have control of the urls so I used {root: '/'} to say we can go all the way up to root.

[benkaiser]

@Eaterofcode is there any other major problems that needed fixing on windows? or does it all work now?

[the-eater]

I dont know, been busy with my own project, Im sorry

[benkaiser]

@Eaterofcode that is fine, if someone finds this thread and is interested they can create the patches needed for window support

[benkaiser]

Some logs when hard rescanning then reloading the page (perhaps the wrong location stored in file):

C:\Users\benkaiser\GIT\node-music-player>node app.js
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
Express server listening on port 2000
0 tracks deleted
C:\Users\benkaiser\GIT\node-music-player\node_modules\musicmetadata\lib\index.js
:66
    }, done, opts.hasOwnProperty('duration'), fsize);
                 ^
TypeError: Cannot read property 'hasOwnProperty' of undefined
    at Stream.<anonymous> (C:\Users\benkaiser\GIT\node-music-player\node_modules
\musicmetadata\lib\index.js:66:18)
    at Stream.g (events.js:199:16)
    at Stream.emit (events.js:107:17)
    at drain (C:\Users\benkaiser\GIT\node-music-player\node_modules\musicmetadat
a\node_modules\through\index.js:36:16)
    at Stream.stream.queue.stream.push (C:\Users\benkaiser\GIT\node-music-player
\node_modules\musicmetadata\node_modules\through\index.js:45:5)
    at Stream.write (C:\Users\benkaiser\GIT\node-music-player\node_modules\music
metadata\node_modules\through\index.js:14:43)
    at Stream.stream.write (C:\Users\benkaiser\GIT\node-music-player\node_module
s\musicmetadata\node_modules\through\index.js:26:11)
    at ReadStream.ondata (_stream_readable.js:540:20)
    at ReadStream.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)

C:\Users\benkaiser\GIT\node-music-player>l^Nn^N

C:\Users\benkaiser\GIT\node-music-player>node app.js
connect.multipart() will be removed in connect 3.0
visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives
connect.limit() will be removed in connect 3.0
Express server listening on port 2000
Error: ENOENT, stat 'C:\Users\benkaiser\GIT\node-music-player\Users\benkaiser\Mu
sic\soundcloud\smash_mouth___all_star_teddy_cream___mimmo_bootleg_.mp3'
    at Error (native)
Error: ENOENT, stat 'C:\Users\benkaiser\GIT\node-music-player\Users\benkaiser\Mu
sic\soundcloud\smash_mouth___all_star_teddy_cream___mimmo_bootleg_.mp3'
    at Error (native)

[benkaiser]

I fixed the above issues and now upon installing soundcloud downloading, scanning the library and most other features (except youtube unless ffmpeg is installed) should work.

If any other issues arise for windows please add them in their own issue.