Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing makerOptionsPath package option #151

Closed
jupapios opened this issue Mar 29, 2022 · 1 comment
Closed

Missing makerOptionsPath package option #151

jupapios opened this issue Mar 29, 2022 · 1 comment
Assignees
Milestone

Comments

@jupapios
Copy link

jupapios commented Mar 29, 2022

Describe the bug

It seems the option to override the maker options was removed, this is commit adb8bb9 that originally added support to that option. It is also listed in the changelog https://github.com/bennymeg/nx-electron/blob/master/CHANGELOG.md#features but when you try to use it it doesn't exist which can be confirmed in the code from master.

To Reproduce

  • Modify the makerOptionsPath option to use a different file (remove the default one)
  • You see this error Error: ENOENT: no such file or directory, stat '.../apps/desktop-shell/src/app/options/maker.options.json'

Expected behavior
It should use the maker options path you defined

The makerOptionsPath option was supported in pre 12.0.0 versions of nx-electron, I'm using it in a project that uses nx-electron@11.4.1 and it works just as expected, it seems to have been remove in 12.x.x

Desktop (please complete the following information):

  • OS: OSx
  • Nx Electron Version 12.10.0
@bennymeg
Copy link
Owner

Thanks for letting me know,
I will check it out.

@bennymeg bennymeg self-assigned this Apr 1, 2022
@bennymeg bennymeg added this to the v13 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants