Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github linting action / pnpm format #138

Closed
wants to merge 1 commit into from

Conversation

delight
Copy link
Contributor

@delight delight commented Sep 10, 2023

  • gh action is good
  • code is formated with prettier
  • but a lot of linter errors and warnings are in the code base

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2023

⚠️ No Changeset found

Latest commit: 8c75349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ato-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 4:04pm

@bennymi
Copy link
Owner

bennymi commented Sep 10, 2023

@delight you were quick on this one haha thanks for the PR, but I'll tackle this one myself later I think😄 I want to revisit all my rules and make sure I see exactly what the linting step does. I'll leave the PR open for now but I might close it later. Hope that's okay for you 😅

@delight
Copy link
Contributor Author

delight commented Sep 10, 2023

@delight you were quick on this one haha thanks for the PR, but I'll tackle this one myself later I think😄 I want to revisit all my rules and make sure I see exactly what the linting step does. I'll leave the PR open for now but I might close it later. Hope that's okay for you 😅

I can create a PR with just the gh-lint-action instead ... so that you can use it whenever your linting rules are done

@bennymi
Copy link
Owner

bennymi commented Sep 11, 2023

@delight I added prettier and linting into the workflow in #139 so I'm closing this. Thanks for your PR though :)

@bennymi bennymi closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants