-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no worky for https (1.0.2 5c55565d6c5) #141
Comments
Also, on R15
|
Can you try with a more recent version of erlang? On 17.3.3:
|
More recent? This is 17.3 from ArchLinux package, I don't have more recent than that at this moment. |
yeah it should be installed from the tag :/ either using kerl or manually. Preety sure you experiment an issue solved there: https://github.com/erlang/otp/releases/tag/OTP-17.3.2 Now, I am not sure what to do. I probably need to check the erlang release to enable/disable that check ... But then it would make ssl less useful. Thoughts? |
oh. I'll flag the package for update then. What about on R15? it's no longer supported? |
the issue is that the fix is not part of an "official" release even if tagged.... |
So, going to After discussing around I don't think the issue is specific to hackney but rather an issue in the SSL application and not related to the validation app imo. |
SO to be clear, on hackney side I have no solutions except reverting the validation check or invite people to use the latest version. I will think more about it today and try to see if there are others alternatives. |
@benoitc how about the following hack: check for
|
Didn't test, but imho such rebar hook may works. |
Hrm cool idea, if we can do it at compile time then we have a solution. Checking the version on each connect would impact the performances. |
Sure, that's need to do on compile time. Rebar pre_hooks with compile looks the right place for it. |
we need to find the right versions to test though. For example it doesn't work on R15B01 but is on R16B03-1 ... |
Fix the following cases: - R14/R15 doesn't support the option `server_name_indication`, on these platform we only do simple certificate verificaton - 17 < 17.3.2 has a broken SSL validaton, on these versions we only skip the validation. - R16 and any verson > 17.3.2 we use hostname SSL validation. fix #141
@benoitc AFAIK, only 17.3.0 and 17.3.1 has broken SSL. downgrading to 17.2 is one of the option to solve 17.3 ssl problem. |
On R15 (debian) 2> hackney:get(<<"https://www.youtube.com">>). |
+1 on @gdamjan error for R14B04 |
Archlinux Erlang package just got updated to 17.3.4 but I still get the same error:
|
i don't reproduce it here. Just retried on another machine. Are you sure it On Sun, Dec 7, 2014 at 10:28 AM, Дамјан Георгиевски <
|
urgh. right, I was using the -nox package and it got synced a bit later. works on 17.3.4
|
The text was updated successfully, but these errors were encountered: