fix: Remove duplicate key value in helm chart for kubelink configs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key RUN_HELM_INSTALL_IN_ASYNC_MODE is set in templates/kubelink.yaml, so having the value is redundant and causes an error when installing via fluxcd2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since argocd is not yet on my cluster, I'm trying to bootstrap Devtron using fluxcd v2. It installs on the cluster using regular helm just fine, but fluxcd validates the output in a stricter manner.
It complains of a duplicate key entry for RUN_HELM_INSTALL_IN_ASYNC_MODE.
In the kubelink.configs section values.yaml, a default for RUN_HELM_INSTALL_IN_ASYNC_MODE is defined as false. In templates/kubelink.yaml there is a conditional that appends that same key below, meaning in the rendered output it appears twice.
This causes fluxcd to throw the error. This issue is for a different helm chart, but it is along the same lines.
Fixes
Removed the redundant key from kubelink.configs defaults.