Allow for stringified options keys

[julik]

I've reworked the patch now to not convert the hashes every time (since this could introduce memory leaks into the system when too many mailcious string keys would be sent).

[julik]

Please note that due to some bug with Github you actually need to pull in this commit
https://github.com/julik/pony/commit/4c462028f0988ca66002e164898052ea18c34f65
I'm really sorry for all the mess.

[benprew]

Julik,

Thanks for working on this and I appreciate the spelling fixes too :).

I'd prefer one of two solutions:

1. Use the Hashie gem instead of writing SymbolProxy
   (https://github.com/intridea/hashie)
2. If you're using yaml or similar to write config files, you can
   prepend keys with ':' in the yaml file and ruby will interpret them as
   symbols (http://stackoverflow.com/questions/800122/best-way-to-convert-strings-to-symbols-in-hash)

Thanks

--Ben

On Mon, Jan 9, 2012 at 3:16 AM, Julik Tarkhanov
reply@reply.github.com
wrote:

I've reworked the patch now to not convert the hashes every time (since this could introduce memory leaks into the system when too many mailcious string keys would be sent).

You can merge this Pull Request by running:

 git pull https://github.com/julik/pony master

Or you can view, comment on it, or merge it online at:

 #7

-- Commit Summary --

• Allow for stringified option keys and stringified "via" option
• Revert "Allow for stringified option keys and stringified "via" option"
• depricated -> deprecated typo
• Allow for stringified keys in configs

-- File Changes --

M lib/pony.rb (59)
M spec/pony_spec.rb (25)

-- Patch Links --

 https://github.com/benprew/pony/pull/7.patch
 https://github.com/benprew/pony/pull/7.diff

---

Reply to this email directly or view it on GitHub:
#7

[julik]

Thanks for the quick reaction! I'll take a stab at using Hashie, if you don't object to it becoming a dependency.

Specifying symbols in YAML is an option but the first Google result for it will likely be the Ruby yaml class notation which is ugly.

[julik]

Hm. Unfortunately IndifferentAccess is only in the 2.0 branch of Hashie which is not stable yet. Is it good for Pony to depend on a prerelease gem? Maybe you could include my stub as a temporary solution and replace it with Hashie once they push out 2.0?

[konklone]

I'd like to draw attention back to this pull request. Applications using safe_yaml to ensure that their YAML processing is naive and to-spec (doesn't do any Ruby-specific processing) won't get that symbol conversion.

This is an example of the manual conversion I need to do in my own code now:
https://github.com/sunlightlabs/scout/blob/master/config/email.rb#L49

So one way or the other, pony should stop depending on Ruby-specific YAML processing.

[konklone]

This is still an issue -- libraries in Ruby-land, where configuration is frequently read in from YAML files, should accept either string or symbol keys. Ruby-specific processing of YAML files, which symbol keys depends on, is a security antipattern.

[benprew]

Closing this PR, but opening issue #20 to put together a fix.