Add tolerance for best_purity checks

bensadeghi · Jun 5, 2020 · 485231b · 485231b
1 parent 579062f
commit 485231b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/classification/tree.jl b/src/classification/tree.jl
@@ -148,7 +148,7 @@ module treeclassifier
                     unsplittable = false
                     purity = -(nl * purity_function(ncl, nl)
                              + nr * purity_function(ncr, nr))
-                    if purity > best_purity
+                    if purity > best_purity + 1e-12
                         # will take average at the end
                         threshold_lo = last_f
                         threshold_hi = curr_f

diff --git a/src/regression/tree.jl b/src/regression/tree.jl
@@ -148,7 +148,7 @@ module treeregressor
                 if lo-1 >= min_samples_leaf && n_samples - (lo-1) >= min_samples_leaf
                     unsplittable = false
                     purity = (rsum * rsum / nr) + (lsum * lsum / nl)
-                    if purity > best_purity
+                    if purity > best_purity + 1e-12
                         # will take average at the end, if possible
                         threshold_lo = last_f
                         threshold_hi = curr_f