Add :exec-dir option to change working directory of executions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
force-pushed
the
exec-dir
branch
from
3666a86
to
e18778e
Compare
|
@danielcompton @bensu have you had a chance to look at this yet? Green tests 🍏 |
| @@ -68,7 +75,7 @@ | |||
| as it happens by default." | |||
| ([cmd] (sh cmd {:verbose true})) | |||
| ([cmd opts] | |||
| (let [proc (exec! cmd) | |||
| (let [proc (exec! cmd (:exec-dir opts)) | |||
There was a problem hiding this comment.
I'd probably prefer to see the logic for switching based on whether :exec-dir exists here, rather than further down the call stack. At the moment you have to go three layers deep to see what's happening. OTOH, you're still going to end up with roughly the same code, just a little more verbose. Perhaps you could just add a comment explaining what's happening?
|
Hey I've left some comments. It could also be good to have some tests for this new behaviour, (perhaps with boot?) and some brief docs on the config option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
A pared back, explicit alternate to to #69