Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configuration versioning #3052

Merged
merged 7 commits into from
Nov 28, 2022
Merged

feat: configuration versioning #3052

merged 7 commits into from
Nov 28, 2022

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Sep 29, 2022

This PR address configuration versioning between changes

This PR will also add a compatibility layers and versioning, which allow users to
explicitly specify configuration fields

version: v1
api_server:
    ...
runner:
    ...

To maintain compatibility, if given configuration does not specify version, then by
default we will use v1, which is the old configuration format

@codecov
Copy link

codecov bot commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #3052 (0cb8d9b) into main (bb7abc4) will increase coverage by 0.30%.
The diff coverage is 48.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3052      +/-   ##
==========================================
+ Coverage   33.45%   33.75%   +0.30%     
==========================================
  Files         106      108       +2     
  Lines        9769     9846      +77     
  Branches     1685     1694       +9     
==========================================
+ Hits         3268     3324      +56     
- Misses       6270     6293      +23     
+ Partials      231      229       -2
Impacted Files Coverage Δ
...c/bentoml/_internal/runner/runner_handle/remote.py 0.00% <ø> (ø)
src/bentoml/_internal/configuration/containers.py 47.19% <18.03%> (+1.88%) ⬆️
src/bentoml/_internal/configuration/v1/__init__.py 48.83% <48.83%> (ø)
src/bentoml/_internal/configuration/helpers.py 65.75% <65.75%> (ø)
src/bentoml/_internal/utils/lazy_loader.py 78.37% <80.00%> (-1.04%) ⬇️
src/bentoml/_internal/configuration/__init__.py 61.84% <100.00%> (ø)

@aarnphm aarnphm marked this pull request as ready for review October 2, 2022 05:23
@aarnphm aarnphm requested review from ssheng, parano and a team as code owners October 2, 2022 05:23
@aarnphm aarnphm requested review from larme and removed request for a team October 2, 2022 05:23
@aarnphm aarnphm force-pushed the refactor/configuration branch 2 times, most recently from c20fa0c to ec85e25 Compare October 2, 2022 07:30
aarnphm
aarnphm commented Oct 2, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
bentoml/__init__.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/__init__.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/__init__.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/containers.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/containers.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/containers.py Outdated Show resolved Hide resolved
bentoml/_internal/configuration/containers.py Outdated Show resolved Hide resolved
@aarnphm aarnphm requested a review from sauyon October 4, 2022 05:31
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 4, 2022
@aarnphm
docs: tracing and configuration
ff4412b 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm mentioned this pull request Oct 4, 2022
Closed
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 5, 2022
@aarnphm
docs: tracing and configuration
b4a8d99 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm force-pushed the refactor/configuration branch 2 times, most recently from 6c7a551 to 9f38799 Compare October 5, 2022 03:02
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 5, 2022
@aarnphm
docs: tracing and configuration
b7412d5 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 5, 2022
@aarnphm
docs: tracing and configuration
c4c69a8 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 5, 2022
@aarnphm
docs: tracing and configuration
9d5a5a0 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Oct 5, 2022
@aarnphm
docs: tracing and configuration
aa9a660 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm mentioned this pull request Oct 5, 2022
Merged
@aarnphm aarnphm force-pushed the refactor/configuration branch 5 times, most recently from 6c3cc60 to fcab47e Compare October 5, 2022 23:52
@aarnphm aarnphm enabled auto-merge (squash) November 8, 2022 23:58
@aarnphm aarnphm disabled auto-merge November 9, 2022 00:27
bojiang
bojiang requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@bojiang bojiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need mods mentioned above

@aarnphm aarnphm force-pushed the refactor/configuration branch 2 times, most recently from e4f0415 to ca27fc5 Compare November 21, 2022 04:43
@aarnphm aarnphm requested a review from bojiang November 21, 2022 05:45
@aarnphm aarnphm requested a review from bojiang November 21, 2022 08:58
@aarnphm
feat: refactor configuration options for tracing
65bc3ea 
enable tracing tests for grpc

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
chore: renaming fn
1e39b78 
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
fix: schema
9987aef 
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
revert: unrelated change
d10b54d 
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
feat: expose save_config and load_config API
a77ba28 
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
chore: add backward layer
3d3af62 
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from bojiang November 24, 2022 09:03
@aarnphm aarnphm merged commit 7468acc into bentoml:main Nov 28, 2022
@aarnphm aarnphm deleted the refactor/configuration branch November 28, 2022 14:40
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Dec 14, 2022
@aarnphm
docs: tracing and configuration
c333a1a 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
bojiang pushed a commit to aarnphm/BentoML that referenced this pull request Dec 24, 2022
@aarnphm @bojiang
docs: tracing and configuration
e0def6c 
depends on bentoml#3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
bojiang pushed a commit that referenced this pull request Dec 24, 2022
@aarnphm
docs: tracing and configuration (#3067)
e4499f8 
* docs: tracing and configuration

depends on #3052

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* chore: update jaeger image

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

* docs: finalize

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojiang bojiang bojiang approved these changes

@ssheng ssheng Awaiting requested review from ssheng

@parano parano Awaiting requested review from parano

@larme larme Awaiting requested review from larme larme is a code owner automatically assigned from bentoml/bentoml-reviewers

@sauyon sauyon Awaiting requested review from sauyon

Assignees

@sauyon sauyon

@bojiang bojiang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: configuration versioning
3 participants
@aarnphm @bojiang @sauyon