Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dispatcher): refactor out training code #3663

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Mar 14, 2023

Refactor to make this code more reasonable.

@sauyon sauyon requested a review from a team as a code owner March 14, 2023 01:56
@sauyon sauyon requested review from ssheng and removed request for a team March 14, 2023 01:56
@sauyon sauyon changed the title refactor out training code chore(dispatcher): refactor out training code Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3663 (c66867a) into main (f503a68) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3663      +/-   ##
==========================================
+ Coverage   31.74%   31.90%   +0.15%     
==========================================
  Files         149      149              
  Lines       12149    12090      -59     
  Branches     2001     1984      -17     
==========================================
  Hits         3857     3857              
+ Misses       8008     7949      -59     
  Partials      284      284              
Impacted Files Coverage Δ
src/bentoml/_internal/marshal/dispatcher.py 0.00% <0.00%> (ø)

aarnphm
aarnphm previously approved these changes Mar 14, 2023
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if github has a better diff view

@sauyon
Copy link
Contributor Author

sauyon commented Mar 14, 2023

This is just a nightmare diff in general :P

Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @bojiang

@aarnphm aarnphm merged commit eafcc9b into bentoml:main Mar 16, 2023
@aarnphm aarnphm deleted the training-refactor branch March 16, 2023 01:04
sauyon added a commit to sauyon/BentoML that referenced this pull request Mar 17, 2023
sauyon added a commit to sauyon/BentoML that referenced this pull request Apr 18, 2023
sauyon added a commit to sauyon/BentoML that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants