feat(ci): pdm and hatchling #4056

aarnphm · 2023-07-16T17:23:30Z

What does this PR address?

Finally, we are off the ever buggy and hacky setuptools.

Before submitting:

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

github-actions · 2023-07-17T04:17:09Z

Package	Statements
bentoml	68.37% (10530 / 15400)
Summary	68.37% (10530 / 15400)

aarnphm · 2023-07-17T04:19:18Z

cc @frostming would love to hear your feedback here. Am I doing got this right?

frostming · 2023-07-17T06:50:33Z

good to see this happening, but there seem to be changes irrelevant to pdm(such as framework changes), can you make them separate PRs?

frostming

Can we remove the dev-requirements.txt and test-requirements.txt now?

.github/workflows/ci.yml

src/bentoml/_internal/configuration/__init__.py

aarnphm · 2023-07-17T13:48:20Z

good to see this happening, but there seem to be changes irrelevant to pdm(such as framework changes), can you make them separate PRs?

The tests change are to make it works with all of the integration changes from PDM.

aarnphm · 2023-07-17T13:49:37Z

Can we remove the dev-requirements.txt and test-requirements.txt now?

dev-requirements.txt are still used for devcontainer and some other branches. I think it is ok to leave it here. I believe I also use this for bazel as well.

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

let click handle version parsing lazily, instead of eager import Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Use fixture to avoid race between running xdist Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: aarnphm-ec2-dev <29749331+aarnphm@users.noreply.github.com>

…modern Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

.devcontainer/lifecycle/post-start

.github/workflows/cqa.yml

.gitignore

.readthedocs.yaml

DEVELOPMENT.md

examples/triton/onnx/README.md

Co-authored-by: Frost Ming <me@frostming.com>

.github/workflows/cqa.yml

Co-authored-by: Frost Ming <me@frostming.com>

pyproject.toml

Co-authored-by: Frost Ming <me@frostming.com>

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

Signed-off-by: Frost Ming <me@frostming.com>

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

aarnphm requested a review from a team as a code owner July 16, 2023 17:23

aarnphm requested review from ssheng and removed request for a team July 16, 2023 17:23

aarnphm mentioned this pull request Jul 16, 2023

fix(tests): make sure pytest tests works #3552

Closed

aarnphm force-pushed the feat/pdm-and-modern branch 4 times, most recently from c9e02bb to 3a5391f Compare July 17, 2023 01:16

aarnphm requested a review from frostming July 17, 2023 04:18

frostming requested changes Jul 17, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

src/bentoml/_internal/configuration/__init__.py Outdated Show resolved Hide resolved

aarnphm added 15 commits July 17, 2023 09:55

feat: pdm and modern system packaging

6c7acf8

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix(tests): make sure pytest tests works

7d45fd9

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: update lock and development instruction

d0a86b6

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

feat: pdm build works with both sdist and wheel

e9e7a4b

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: reduce CI workers

613a15a

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: make tests a composite tasks and unit a bit faster

3a8d902

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: lock dev depdendencies and resolve tensorflow-io-gcs-filesystem

7321c5a

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: run sync for pre-all

8e78a01

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

feat: add coverage per PR

e3248c4

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: cov bentoml and generate monitoring coverage

12e2a66

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix(docs): using metadata to get version of BentoML

1752810

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: e2e tests

2c6875c

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: update packages tests

3af73ac

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: install dependencies

ec553a9

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: remove flaky and resolve fastapi for tests

5cefcc3

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

aarnphm added 7 commits July 17, 2023 13:23

chore: improve CI speed and import speed

49de7bc

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

perf: CLI import speed

7fa08b4

let click handle version parsing lazily, instead of eager import Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix(docs): mock frameworks module

22c4e34

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: consistent regression tests

426d99d

Use fixture to avoid race between running xdist Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

revert: remove fail on warning for now

e0f571e

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: ignore transformers classifier unit

50b7d2f

Signed-off-by: aarnphm-ec2-dev <29749331+aarnphm@users.noreply.github.com>

chore: ignore fastai tests

c166d26

Signed-off-by: aarnphm-ec2-dev <29749331+aarnphm@users.noreply.github.com>

aarnphm mentioned this pull request Jul 18, 2023

feat(build): --push and --containerize #4055

Merged

5 tasks

aarnphm added 3 commits July 18, 2023 00:57

merge: branch 'main' of github.com:bentoml/BentoML into feat/pdm-and-…

a9e3145

…modern Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

ci: xfail tests run on CI for regression for now

66302b5

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: hashing gcs-filesystem to support windows

4235cac

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

frostming requested changes Jul 19, 2023

View reviewed changes

aarnphm and others added 2 commits July 19, 2023 03:51

Update .devcontainer/lifecycle/post-start

80c9d49

Co-authored-by: Frost Ming <me@frostming.com>

Update .readthedocs.yaml

ee75b10

Co-authored-by: Frost Ming <me@frostming.com>

aarnphm commented Jul 19, 2023

View reviewed changes

.github/workflows/cqa.yml Outdated Show resolved Hide resolved

aarnphm and others added 2 commits July 19, 2023 03:53

Update .github/workflows/cqa.yml

2004d56

Update .gitignore

edb1490

Co-authored-by: Frost Ming <me@frostming.com>

aarnphm commented Jul 19, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

aarnphm and others added 7 commits July 19, 2023 03:57

Update pyproject.toml

8992238

Update DEVELOPMENT.md

cada407

Co-authored-by: Frost Ming <me@frostming.com>

revert: examples

335fc45

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

fix: missing quotes for rtd

ba352c2

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: update locks

78e0d30

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

chore: update pdm.lock

624a573

Signed-off-by: Frost Ming <me@frostming.com>

chore: exclude version

9ec4f01

Signed-off-by: Frost Ming <me@frostming.com>

aarnphm requested a review from frostming July 19, 2023 09:35

chore: skipping mlflow on GitHub actions for now

ce62135

Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>

frostming approved these changes Jul 19, 2023

View reviewed changes

aarnphm merged commit d4c5908 into main Jul 20, 2023

aarnphm deleted the feat/pdm-and-modern branch July 20, 2023 01:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ci): pdm and hatchling #4056

feat(ci): pdm and hatchling #4056

aarnphm commented Jul 16, 2023 •

edited

Loading

github-actions bot commented Jul 17, 2023 •

edited

Loading

aarnphm commented Jul 17, 2023

frostming commented Jul 17, 2023

frostming left a comment

aarnphm commented Jul 17, 2023

aarnphm commented Jul 17, 2023

feat(ci): pdm and hatchling #4056

feat(ci): pdm and hatchling #4056

Conversation

aarnphm commented Jul 16, 2023 • edited Loading

What does this PR address?

Before submitting:

github-actions bot commented Jul 17, 2023 • edited Loading

aarnphm commented Jul 17, 2023

frostming commented Jul 17, 2023

frostming left a comment

Choose a reason for hiding this comment

aarnphm commented Jul 17, 2023

aarnphm commented Jul 17, 2023

aarnphm commented Jul 16, 2023 •

edited

Loading

github-actions bot commented Jul 17, 2023 •

edited

Loading