perf: only open one GRPC channel per GrpcClient
#4112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judahrand
changed the title
GrpcClientGrpcClient
judahrand
force-pushed
the
grpc-channel
branch
2 times, most recently
from
9601e1d
to
209f058
Compare
It is best practice to keep the channel open for the lifecycle of the client to avoid unnecessary reconnects.
judahrand
force-pushed
the
grpc-channel
branch
from
209f058
to
0c3ec79
Compare
frostming
reviewed
Aug 15, 2023
| service=service_name, | ||
| _grpc_channel_timeout=timeout, | ||
| ) | ||
| @cached_property |
There was a problem hiding this comment.
Any reason why this has to be cached?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
It is best practice to reuse channels where possible: https://grpc.io/docs/guides/performance/#general
For me, locally, this reduces latency by about by about 3ms for sync calls an 2ms for async calls.
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.