fix: fix deploy cli & sdk #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FogDong <fog@bentoml.com>
frostming
reviewed
Jan 9, 2024
Comment on lines
+214
to
+218
| @click.argument( | ||
| "name", | ||
| type=click.STRING, | ||
| required=True, | ||
| ) |
There was a problem hiding this comment.
I didn't get why this is added but the args are removed from the function
There was a problem hiding this comment.
By adding args we can use cli like this:
bentoml deployment update my-deploy --scaling-min=1
There was a problem hiding this comment.
Oh, I am looking at the wrong line.
frostming
approved these changes
Jan 10, 2024
frostming
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: FogDong <fog@bentoml.com>
frostming
pushed a commit
that referenced
this pull request
Feb 1, 2024
Signed-off-by: FogDong <fog@bentoml.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.