This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
fix: small fixes #59
Merged
fix: small fixes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjmachan
commented
Dec 16, 2021
jjmachan
commented
yubozhao
reviewed
Dec 20, 2021
| @@ -105,9 +105,16 @@ def deploy(name, operator, bento, display_deployment_info, file): | |||
| deployment_config_path = save_deployment_config( | |||
| deployment_config.deployment_config, Path.cwd() | |||
| ) | |||
| deployment_config_path_relative = deployment_config_path.relative_to( | |||
There was a problem hiding this comment.
Will we always expect a Path instance here?
There was a problem hiding this comment.
yep, the save_deployment_config() above creates and returns the config path as a Path instance.
yubozhao
added a commit
that referenced
this pull request
Dec 21, 2021
|
@jjmachan oops, accidentally merged this PR. Please open another PR when it is ready |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.