Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cards now paginate independently #80

Merged
merged 21 commits into from
Jun 19, 2024
Merged

Conversation

benvinegar
Copy link
Owner

This is a major refactor. Instead of having a big single loader that loads all the data, each card has been converted to a Remix Full Stack Component that handles its own data fetching.

This also adds card pagination, using back/forward arrows now visible at the bottom of each component.

counterscale-paginated-cards.mov

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 60.98039% with 199 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (6ce3675) to head (aa8f89d).

Files Patch % Lines
app/analytics/query.ts 21.68% 65 Missing ⚠️
app/routes/resources.country.tsx 39.13% 42 Missing ⚠️
app/routes/resources.browser.tsx 61.90% 16 Missing ⚠️
app/routes/resources.device.tsx 61.90% 16 Missing ⚠️
app/routes/resources.paths.tsx 61.90% 16 Missing ⚠️
app/routes/resources.referrer.tsx 61.90% 16 Missing ⚠️
server.ts 0.00% 9 Missing ⚠️
app/lib/utils.ts 22.22% 7 Missing ⚠️
app/components/PaginationButtons.tsx 87.23% 6 Missing ⚠️
app/components/PaginatedTableCard.tsx 92.30% 5 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   79.19%   71.19%   -8.01%     
==========================================
  Files          18       25       +7     
  Lines        2264     2638     +374     
  Branches      149      147       -2     
==========================================
+ Hits         1793     1878      +85     
- Misses        466      755     +289     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 848569e into main Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant