Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to angular 13 #56

Merged
merged 1 commit into from
Feb 10, 2022
Merged

update to angular 13 #56

merged 1 commit into from
Feb 10, 2022

Conversation

dfa1234
Copy link
Collaborator

@dfa1234 dfa1234 commented Feb 9, 2022

library build with ng-packagr

library build with ng-packagr
@dfa1234
Copy link
Collaborator Author

dfa1234 commented Feb 9, 2022

#55 Hi here what I propose

@dfa1234 dfa1234 merged commit 8f7b829 into master Feb 10, 2022
@bergben
Copy link
Owner

bergben commented Feb 10, 2022

Nice @dfa1234 thanks!

Did you test the library? Want to release a new version?

@bergben
Copy link
Owner

bergben commented Feb 10, 2022

A new Demo on Plunkr (or now rather Stackblitz) would be nice? See readme

@dfa1234
Copy link
Collaborator Author

dfa1234 commented Feb 11, 2022

@bergben You are perfectly right, before all I wanted to prepare a demo on stackblitz. I hope there will be no regression!

For you question on ng2-pica, the problem is that I could not do npm i ng2-pica in this project anymore. I think the problem is that ng2-pica need to be upgraded as well with the new angular. To move quicker I simply took your service from ng2-pica and moved it here, made some upgrade on the script (typescript related) and imported pica directly. It's the main change I did in the source code.

I keep you updated when I have a stackbliz working, but I'm also very short on time likely, I expect to work on it next week.

@bergben bergben deleted the update-to-angular-13 branch February 11, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants