Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

"Instant" toolbar #185

Merged
merged 3 commits into from
Jul 16, 2013
Merged

"Instant" toolbar #185

merged 3 commits into from
Jul 16, 2013

Conversation

marcobarbosa
Copy link
Contributor

Clicking the element instantly shows the toolbar - wether there is a selection range set or not.

@hussfelt
Copy link

It would be awesome to see this enhancement in hallo, as we need to adjust it for our needs, without modifying the core. 👍 Thanks!

bergie added a commit that referenced this pull request Jul 16, 2013
@bergie bergie merged commit 0d0ff47 into bergie:master Jul 16, 2013
@bergie
Copy link
Owner

bergie commented Jul 16, 2013

Thanks for submitting a new toolbar! I think with toolbars and plugins people should be able to modify the Hallo experience to be exactly the one they need

@hussfelt
Copy link

@bergie Thanks for the merge! :-) Awesome work @marcobarbosa :squirrel:

@marcobarbosa
Copy link
Contributor Author

Thanks @bergie !!

The reason I was hoping to get this into the main repository as a plugin or toolbar is that I use hallo (as other packages) in a vendor folder (usually bower_components). So I can't touch the files there or the changes would be lost as soon as I update the components with bower. You probably know this already just wanted to make clear.

I cannot thank you enough to have designed hallo in such a modular way as you did with plugins and toolbars.
Good stuff!

I'll definitely consider pushing more improvements as plugins if I find them.

Thanks again! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants