Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tables response #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix tables response #3

wants to merge 1 commit into from
+5 −4

Conversation

datamuc
Copy link

@datamuc datamuc commented Mar 8, 2017

This fixes the table datastructure
http://docs.grafana.org/plugins/developing/datasources/

@jakebrinkmann jakebrinkmann mentioned this pull request May 3, 2017
Merged
@vbichov
Copy link

vbichov commented May 29, 2017

will this ever be merged?
just wasted 2 hours of my life on this :(

@blindgaenger
Copy link

same here 😢

I think @bergquist is still on parental leave as he stated on his profile.

@mohierf
Copy link

mohierf commented Sep 21, 2017

Note that this PR is not currently functional with the most recent Grafana 4. To make it correct, I had to prepend type: "table", here: https://github.com/bergquist/fake-simple-json-datasource/blob/master/index.js#L45

@eddy-geek eddy-geek mentioned this pull request Jan 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroconte pedroconte pedroconte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@datamuc @vbichov @blindgaenger @mohierf @pedroconte