Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the correct file name and hash #20

Merged
merged 6 commits into from
Nov 2, 2015
Merged

updated the correct file name and hash #20

merged 6 commits into from
Nov 2, 2015

Conversation

changsiyao
Copy link
Contributor

file name and hash was still the example, changed it to our data.

@changsiyao
Copy link
Contributor Author

Also fixed Jiang's code for unzipping

@briankleinqiu
Copy link
Contributor

Both commits look good to me

@BenjaminHsieh
Copy link
Contributor

talked to ross about hash for data, we should make hash for the unzipped folder instead

@briankleinqiu
Copy link
Contributor

also separate the graphing code in a different file than the summary statistics code if possible

and adding some comments and docstring would be useful

@changsiyao
Copy link
Contributor Author

What do you mean by separate the graphing code in a different file than the summary statistics code? I only have the graphing code in that file. Jiang has the summary statistics code.

@changsiyao
Copy link
Contributor Author

Also, how do you make hash for the unzipped folder which is a directory, not a file.

changsiyao added a commit that referenced this pull request Nov 2, 2015
@changsiyao changsiyao merged commit 8a19d39 into berkeley-stat159:master Nov 2, 2015
@changsiyao
Copy link
Contributor Author

eh... accidentally merged... what should I do...

@BenjaminHsieh
Copy link
Contributor

Revert the new pull request I made

@BenjaminHsieh
Copy link
Contributor

Also, for the hashing of directory, check this answer, might help:
http://unix.stackexchange.com/questions/35832/how-do-i-get-the-md5-sum-of-a-directorys-contents-as-one-sum

@BenjaminHsieh BenjaminHsieh mentioned this pull request Nov 2, 2015
@changsiyao
Copy link
Contributor Author

Actually, is there a way to remerge these files. I think we need to make changes to these files by tonight, so let's just use the tgz hash first.

@BenjaminHsieh
Copy link
Contributor

i not sure how, easier to submit a new pull request i think

@changsiyao
Copy link
Contributor Author

I can't, cuz it says there's no new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants