-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated the correct file name and hash #20
Conversation
Also fixed Jiang's code for unzipping |
Both commits look good to me |
talked to ross about hash for data, we should make hash for the unzipped folder instead |
also separate the graphing code in a different file than the summary statistics code if possible and adding some comments and docstring would be useful |
What do you mean by separate the graphing code in a different file than the summary statistics code? I only have the graphing code in that file. Jiang has the summary statistics code. |
Also, how do you make hash for the unzipped folder which is a directory, not a file. |
eh... accidentally merged... what should I do... |
Revert the new pull request I made |
Also, for the hashing of directory, check this answer, might help: |
Actually, is there a way to remerge these files. I think we need to make changes to these files by tonight, so let's just use the tgz hash first. |
i not sure how, easier to submit a new pull request i think |
I can't, cuz it says there's no new changes. |
file name and hash was still the example, changed it to our data.