Documentation, moving files around, test for graph_functions, etc #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionaries (better for testing)
|
This looks good. |
Merged
|
fixed a couple path errors, also created a figures directory in where we can store all the figures we potentially need (currently have sample plots from sub001, run 001), probably someone can merge this and test it out thanks |
briankleinqiu
added a commit
that referenced
this pull request
Nov 14, 2015
Documentation, moving files around, test for graph_functions, etc
BenjaminHsieh
added a commit
to BenjaminHsieh/project-theta
that referenced
this pull request
Nov 15, 2015
Merge branch 'dev' of https://github.com/berkeley-stat159/project-theta into dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys I made some changes to the make_graph, graph_functions to improve readability, fixed some bugs with path, made documentation, and wrote 2 tests for 2 of the function. Also moved everything to the utils folder. Let me know if you have any comments and what people think of the new graph_function implementation.
Edit: Also I realized this includes my previous commits that adds the behav_task functions to produce an "extended" time_course and simple plot, see the first 2 commits