Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: change the setup for path_diversity project #190

Merged

Conversation

jJasonWang
Copy link
Contributor

@jJasonWang jJasonWang commented May 13, 2016

See the last checklist in #122.

In this pull request:

  • I changed the way to import the function from the package. The way to call the function will be path_diversity.function. (import the module by from mousestyles import path_diversity)
  • I created a pytest.ini to avoid the UnusedImport error for style checking.
  • I also changed the tests and function name to make it more robust and consistent. (for path_index and path_filter)

@aksam-ahmad, @alannaiverson, @jcpalumbo3, @sicihuang, @togawa28.
Please help me review the file you created. All the files which used the functions in path_diversity project should have the from mousestyles import path_diversity. Also, all the function should be called by path_diveristy.function. Thanks.

@peterasujan, can you help me double check the setup for pytest.ini is correct? Thanks.

@jJasonWang jJasonWang force-pushed the path_diversity-issue122 branch 4 times, most recently from 923bad6 to 279f775 Compare May 14, 2016 05:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 77.42% when pulling 279f775 on jJasonWang:path_diversity-issue122 into 8089c17 on berkeley-stat222:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 77.42% when pulling abbc93c on jJasonWang:path_diversity-issue122 into dfdf5c3 on berkeley-stat222:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.262% when pulling e51b1ac on jJasonWang:path_diversity-issue122 into 9a6534e on berkeley-stat222:master.

@jJasonWang
Copy link
Contributor Author

@jarrodmillman. Can you help me check this pull request? I might not be able to work on this until 5 pm today. I think that if travis-CI and testing pass, we are ready to merge it.

It is just the setup for path diversity project. I changed it to the way the behavior project setup.

@jarrodmillman
Copy link
Contributor

@jJasonWang Sure, I'll take a look.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.262% when pulling 9e05bd4 on jJasonWang:path_diversity-issue122 into 7c257a8 on berkeley-stat222:master.

@jarrodmillman jarrodmillman merged commit 6abcc51 into berkeley-stat222:master May 14, 2016
@jJasonWang jJasonWang deleted the path_diversity-issue122 branch May 14, 2016 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants