13817 improve logs #479
Merged
13817 improve logs #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 522
💛 - Coveralls |
This should substantially clean up the log files; its defaults match the desired behavior (modulo next commit).
Alphabetizing it causes tests to fail (!), presumably due to a poorly expressed dependency somewhere in one of these gems. (Gems are `require`d in the order listed.) Tracking down where the dependency is would be a pain.
thatandromeda
force-pushed
the
13817_improve_logs
branch
from
9610ceb
to
c86a948
Compare
jsdiaz
reviewed
Aug 21, 2018
| end | ||
| end | ||
|
|
||
| def authenticate_user_from_token! | ||
| user = authentication_token && User.find_by_authentication_token(authentication_token.to_s) | ||
| Rails.logger.info "Attempted login from token #{authentication_token.to_s}" |
jsdiaz
reviewed
Aug 21, 2018
| @@ -74,4 +74,7 @@ | |||
| config.action_mailer.default_url_options = { | |||
| host: (ENV['EMAIL_DOMAIN'] || 'chillingeffects.org') | |||
| } | |||
| config.action_mailer.default_url_options = { host: (ENV['EMAIL_DOMAIN'] || 'chillingeffects.org') } | |||
There was a problem hiding this comment.
these should be updated to lumendatabase.org but perhaps a more through audit should be made as a separate task to fix them all at once
jsdiaz
reviewed
Aug 21, 2018
| @@ -2,11 +2,11 @@ | |||
| require 'devise/orm/active_record' | |||
|
|
|||
| config.secret_key = Rails.application.secrets.devise_secret | |||
| config.mailer_sender = "admin@chillingeffects.org" | |||
| config.mailer_sender = 'admin@chillingeffects.org' | |||
jsdiaz
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge?
YES
What does this PR do?
Adds lograge gem and a log formatter to make logs more readable. Writes API tokens to logs.
Helpful background context (if appropriate)
How can a reviewer manually see the effects of these changes?
Run the app locally with production env and observe
log/production.log.What are the relevant tickets?
Screenshots (if appropriate)
Todo:
[ ] Tests[ ] Documentation[ ] Stakeholder approvalRequires Database Migrations?
NO
Includes new or updated dependencies?
YES