Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate section for hidden quesions added #107

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AvinashAgarwal14
Copy link

Fixes: #106
Before:
Old_Hidden

After:
New_hidden

noOfHiddenQues += 1;
});
if(noOfHiddenQues > 0)
return true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could return true from inside the loop when you get the first hidden question.
That would make it more efficient and faster as in that case comparatively lesser number of iterations would be required.
This could affect the time complexity and efficiency of code drastically when there are larger number of hidden questions.

@sachin235
Copy link

In general, this feature is not important because the hidden questions are already present with a clear distinction.

Moreover, the hidden questions are not visible in the presentation mode. This has already been implemented.

@okpop
Copy link

okpop commented Apr 19, 2019

Actually this would help, especially for mods and admins. If a question is hidden the mods and admins should not have to slug through the greyed out hidden questions to find the non-hidden ones scattered through out. This would simplify the work flow of anyone having to moderate an instance by bringing visible questions more to the front.

In general, this feature is not important because the hidden questions are already present with a clear distinction.

Moreover, the hidden questions are not visible in the presentation mode. This has already been implemented.

@AvinashAgarwal14
Copy link
Author

Actually this would help, especially for mods and admins. If a question is hidden the mods and admins should not have to slug through the greyed out hidden questions to find the non-hidden ones scattered through out. This would simplify the work flow of anyone having to moderate an instance by bringing visible questions more to the front.

In general, this feature is not important because the hidden questions are already present with a clear distinction.
Moreover, the hidden questions are not visible in the presentation mode. This has already been implemented.

@okpop Thank you, are there any changes that I should make with respect to this PR?

@okpop
Copy link

okpop commented Apr 19, 2019

For now no.

@okpop Thank you, are there any changes that I should make with respect to this PR?

@sachin235
Copy link

Actually this would help, especially for mods and admins. If a question is hidden the mods and admins should not have to slug through the greyed out hidden questions to find the non-hidden ones scattered through out. This would simplify the work flow of anyone having to moderate an instance by bringing visible questions more to the front.

In general, this feature is not important because the hidden questions are already present with a clear distinction.
Moreover, the hidden questions are not visible in the presentation mode. This has already been implemented.

@okpop I felt so because even in the current scenario, all the hidden questions are placed after the non-hidden ones. The non-hidden ones are not scattered throughout.

Although I agree that creating a separate section might simplify the work flow even further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden Question should be displayed in a separate section
3 participants