Add explicit selector to input so getValue can get the correct element #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves compatibility with Select2. Select2 will create its own `input` field before the default `input` field used by `best_in_place`. Thus the returned value will not be that of the `best_in_place`'s input. This PR adds a selector class so the selector for the input value is more deterministic. Ref: Issue bernat#510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves compatibility with Select2. Select2 will create its own
inputfield before the defaultinputfield used bybest_in_place.Thus the returned value will not be that of the
best_in_place's input.This PR adds a selector class so the selector for the input value is
more deterministic.
Ref: Issue #510