Ensure :noop sources are always treated as fetchable #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SourceHandler delegates to SourceHandler::*
* SourceHandler::* delegates to Source, except for the :noop handler
which just returns `true`
Closed
bernd
added a commit
that referenced
this pull request
Jun 1, 2019
Changes: * Use factor defaults for `platform` and `target` values. (FooBarQuaxx / #189) * Add `:username` and `:password` parameters to the SVN source handler. (tomeon / #191) * Add `Recipe#extract` method to allow custom extraction logic. * Fix tmux location in getting started guide. (cvhbsk / #195) * Use RPM target for SLES platform. (FooBarQuaxx / #198) * Add `targets` block for target specific setting in recipe. (FooBarQuaxx / #199) * Ensure `:noop` sources are always treated as fetchable. (tomeon / #200) * Allow usage of newer puppet versions. (lukasz-e / #201) * Add sha512 checksum support. (b00ga / #202) * Remove duplicate require. (FooBarQuaxx / #204) * Automatically gunzip gzipped patch files. (davewongillies / #208) * Add a golang util. (davewongillies / #209)
suledani97
pushed a commit
to realCity/fpm-cookery
that referenced
this pull request
Jul 30, 2020
* spec/source_handler_spec.rb: assert that :noop source handler is always fetchable
* source_handler.rb: change fetchable? delegation structure
* SourceHandler delegates to SourceHandler::*
* SourceHandler::* delegates to Source, except for the :noop handler
which just returns `true`
* packager.rb: correct end-of-block comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects an issue introduced by yours truly in 8a710db8. The
:noopsource handler should be considered:fetchable?regardless of whether a non-nil, non-empty URI was provided as the first argument to theRecipe#sourcemethod. Otherwise, much of the recipe-building code won't run.