Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exceptions (allowlist/whitelist) in adblocker #180

Open
jsoverson opened this issue Apr 3, 2020 · 1 comment · May be fixed by #824
Open

Support exceptions (allowlist/whitelist) in adblocker #180

jsoverson opened this issue Apr 3, 2020 · 1 comment · May be fixed by #824
Labels
enhancement New feature or request prs-welcome Feel free to create a PR with code for this :)

Comments

@jsoverson
Copy link

cliqz-oss/adblocker supports exceptions but the functionality is not exposed in puppeteer-extra-plugin-adblocker.

I have a working PR with tests. Let me know if this is a feature you'd accept a PR for.
@brunogaspar brunogaspar added enhancement New feature or request prs-welcome Feel free to create a PR with code for this :) labels Jul 19, 2020
@brunogaspar
Copy link
Collaborator

You're more than welcomed to submit your improvements :)

Thanks!

Wyatt-Stanke added a commit to Wyatt-Stanke/puppeteer-extra that referenced this issue Jul 22, 2023
@Wyatt-Stanke
Support exceptions (allowlist/whitelist) in adblocker
07a83eb 
Fixes berstend#180
@Wyatt-Stanke Wyatt-Stanke linked a pull request Jul 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prs-welcome Feel free to create a PR with code for this :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support exceptions (allowlist/whitelist) in adblocker Wyatt-Stanke/puppeteer-extra
2 participants
@jsoverson @brunogaspar