Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP8 support #6

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Added PHP8 support #6

merged 3 commits into from
Apr 17, 2021

Conversation

boboldehampsink
Copy link
Contributor

No description provided.

@boboldehampsink
Copy link
Contributor Author

@bertoost 👋

@bertoost bertoost changed the base branch from master to develop February 2, 2021 17:38
@bertoost
Copy link
Owner

bertoost commented Feb 2, 2021

I want to test it on PHP8 first. Don't have time yet to create a local environment. Thanks any way for this.

@boboldehampsink
Copy link
Contributor Author

@bertoost any news on this? It's been 3 weeks. I have been using it in production for a while now.

@boboldehampsink
Copy link
Contributor Author

Any news yet?

@boboldehampsink
Copy link
Contributor Author

@bertoost bump

@bertoost
Copy link
Owner

That does not work with me @boboldehampsink .. I am not able to run Craft in PHP8 at the moment. Missing extensions or configurations. Therefore is PHP8 way to new, so not high priority at the moment.
When I am able to, I will try this out.

@boboldehampsink
Copy link
Contributor Author

@bertoost you're not the only one running this plugin ;-) Like I said, I have been running this in production for a few months on PHP 8 now, it is good to go.

@bertoost
Copy link
Owner

I know. Luckely I did not do it for myself..
But I am running locally with Docker and I am not able to complete my image for PHP8.0 and Craft. I can't get some extensions to work. Like ImageMagick is now the only one which is not working. Therefore not needed for this.
I have plans to fix this PR this weekend.

@bertoost bertoost merged commit 617d528 into bertoost:develop Apr 17, 2021
@bertoost
Copy link
Owner

Hope you (and others) are happy ;-) hehe

@boboldehampsink
Copy link
Contributor Author

Thanks bert and sorry for giving you a hard time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants