Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toml file and poetry.lock #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koji
Copy link

@koji koji commented Sep 3, 2022

Add 2 files and this will close #27

  • pyproject.toml
  • poetry.lock

Poetry version 1.1.6

Usage

$ poetry install
$ poetry run python python_file

@after-ephemera
Copy link

Did you want to also remove the requirements.txt file to complete the transition and avoid having two sources of truth? It would probably also be nice to update the README to reflect the new preferred approach for installation.

@koji
Copy link
Author

koji commented Sep 5, 2022

@jkjetty
I think keeping requiremetns.txt is kind of good since that can give options.
In addition, I'm not sure how popular poetry is, so that is the reason why I didn't add any information to the readme.

@after-ephemera
Copy link

@koji I will let the maintainer chime in here to make the final decision but I think poetry is well enough adopted in the community that it's worth dropping the requirements.txt file, even if that may mean some grace period of supporting both. Maintaining two declarations of dependencies over time is probably not a job any of us want to be doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I open a PR for poetry?
2 participants