Added signal handling to prevent new subscriptions #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmuddha
changed the title
|
I was thinking more of a boolean flag to check against, it doesn't seem generally useful to limit number of subscriptions to some arbitrary number. |
A flag seems like a feature less likely to be misused, but I think it's better to ask someone who's planning to use this. |
bmuddha
changed the title
|
Rewrote this feature via flag usage, it's set to true on application startup and can be toggled via USR1 signal. |
polachok
requested changes
Nov 1, 2021
Signal handler listens for USR1 signal and upon receiving one, toggles the switch in PubSub manager. In true state the pubsub manager will allow unlimited number of new subscriptions, in false state no new subscriptions can be created, and thus only the present ones will continue to exist, until they are too removed due to TTL.
polachok
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal handler listens for USR1 signal and upon receiving one, toggles
the switch in PubSub manager. In true state the pubsub manager will
allow unlimited number of new subscriptions, in false state no new
subscriptions can be created, and thus only the present ones will
continue to exist, until they are too removed due to TTL.