Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Port missing commit from v3.x to master #83

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Dec 2, 2020

This PR ports a missing feature from v3.x to master and fix changelog

@migo315
Copy link
Contributor

migo315 commented Dec 2, 2020

Thanks four your contribution. I appreciate your help.

As soon as the automatic checks are done (Travis seems to hang at the moment), I will merge the PR and publish a new release.

@migo315
Copy link
Contributor

migo315 commented Dec 3, 2020

@ajgarlag There is one test failing, because the event "FilterControllerEvent" was renamed to "ControllerEvent" in Symfony 4/5. Can you fix your test?

1) Flagception\Tests\FlagceptionBundle\Listener\RoutingMetadataSubscriberTest::testRouteWithMultipleFeaturesIsNotActive
Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "Symfony\Component\HttpKernel\Exception\NotFoundHttpException". Message was: "Cannot stub or mock class or interface "Flagception\Tests\FlagceptionBundle\Listener\FilterControllerEvent" which does not exist" at
/home/travis/build/bestit/flagception-bundle/tests/Listener/RoutingMetadataSubscriberTest.php:138

@ajgarlag
Copy link
Contributor Author

ajgarlag commented Dec 3, 2020

@migo315 The new ControllerEvent class is declared final, so it cannot be mocked. I've instantiated a real event.

@coveralls
Copy link

coveralls commented Dec 3, 2020

Pull Request Test Coverage Report for Build 221

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.165%

Totals Coverage Status
Change from base Build 216: 0.002%
Covered Lines: 475
Relevant Lines: 479

💛 - Coveralls

@migo315
Copy link
Contributor

migo315 commented Dec 4, 2020

Thanks for your help! Great work! I take a look at the travis build later and merge this PR.

@migo315 migo315 merged commit 14a2ca7 into bestit:master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants