Replace inventory with nodes endpoint
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
This is my first attempt at replacing the
inventorywith the (hopefully) fasternodesendpoint.Please note that I have not tested this against a real puppet server as I do not currently have a working setup. Instead I worked from the documentation and amended our "fake" puppet server accordingly. If someone could test this (reasonably) quickly against a real puppet server, this would be greatly appreciated. Otherwise I will try to rebuild my test environment to do so myself.
Also note that I went with
catalog_environmentas outlined here: #366 (comment)