Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubygems for module testing #43

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add rubygems for module testing #43

merged 1 commit into from
Mar 12, 2024

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Mar 11, 2024

  • install ruby3.0 and build dependencies

  • update puppet version

  • update bolt version

  • update termini version

  • update terraform version

  • install gems into system ruby

  • install voxpupuli-* gems for module testing

  • add gem versions to build_versions.json

  • bind variables from build_versions.json into Dockerfile via build_container.yml

  • add Gemfile with ENV variable bindings

  • set PDK_DISABLE_ANALYTICS

both bundle and system calls should now work

root@ac4ba0658900:/# rake --version
rake, version 13.1.0

root@ac4ba0658900:/# bundle exec rake --version
rake, version 13.1.0

for voxpupuli style modules, mount code into /repo (f.e.) and execute

cd /repo
bundle exec rake validate

- install ruby3.0 and build dependencies
- update puppet version
- update bolt version
- update termini version
- update terraform version

- install gems into system ruby
- install voxpupuli-* gems for module testing

- add gem versions to build_versions.json
- bind variables from build_versions.json into Dockerfile via build_container.yml
- add Gemfile with ENV variable bindings
- set PDK_DISABLE_ANALYTICS

both bundle and system calls should now work

```
root@ac4ba0658900:/# rake --version
rake, version 13.1.0

root@ac4ba0658900:/# bundle exec rake --version
rake, version 13.1.0
```

for voxpupuli style modules, mount code into /repo (f.e.) and execute

```
cd /repo
bundle exec rake validate
```
@rwaffen rwaffen requested a review from a team as a code owner March 11, 2024 17:31
Copy link

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell

@rwaffen rwaffen merged commit 190d4a6 into main Mar 12, 2024
4 checks passed
@rwaffen rwaffen deleted the add_spec_testing branch March 12, 2024 08:03
@rwaffen rwaffen added the enhancement New feature or request label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants