Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dshot not working on latest master build on G4 #11137

Closed
DusKing1 opened this issue Dec 20, 2021 · 24 comments · Fixed by betaflight/unified-targets#545
Closed

Dshot not working on latest master build on G4 #11137

DusKing1 opened this issue Dec 20, 2021 · 24 comments · Fixed by betaflight/unified-targets#545
Assignees
Labels
BUG Bugs are excluded from automatically being marked as stale

Comments

@DusKing1
Copy link
Contributor

DusKing1 commented Dec 20, 2021

Describe the bug

Any Dshot settings (600/300, bidir\no-bidir) does not working on currently master build on G47x target.

To Reproduce

@SteveCEvans grab that AirFleetV11 dev board, flash with latest master build, dshot just won't work.

Expected behavior

Dshot300 can work both in bidir mode and no-bidir mode.

Flight controller configuration

Just use NERC-HYBRIDG4.config

@DusKing1 DusKing1 added the Template: Bug Set by auto_close_issue. label Dec 20, 2021
@github-actions github-actions bot added the Not following template Set by auto_close_issue. label Dec 20, 2021
@github-actions
Copy link

@DusKing1: This issue is being automatically closed because it does not follow the template.

When you open an issue or feature request you are presented with a template. Follow the guidelines.

You can edit your message to fix this and the issue will be automatically reopened.

@DusKing1
Copy link
Contributor Author

@github-actions fk off

@github-actions github-actions bot removed the Not following template Set by auto_close_issue. label Dec 20, 2021
@github-actions github-actions bot reopened this Dec 20, 2021
@haslinghuis haslinghuis added BUG Bugs are excluded from automatically being marked as stale and removed Template: Bug Set by auto_close_issue. labels Dec 20, 2021
@DusKing1
Copy link
Contributor Author

@SteveCEvans any spare time for this?

@SteveCEvans
Copy link
Member

Confirmed, connected to a Tekko32 F3 Metal 4in1 ESC. Also not getting any ESC sensor data. BLHeli configurator is able to communicate though.

@SteveCEvans
Copy link
Member

@DusKing1 Has this ever worked to your knowledge? If so please provide me with the hash of the build.

@DusKing1
Copy link
Contributor Author

@SteveCEvans Can't provide commit hash, ATM, but I remember build 2476 can work nicely.

@SteveCEvans
Copy link
Member

SteveCEvans commented Dec 22, 2021

3d5a0e585cc6a3e9db50b3b1b50602e389511983

Not working for me I'm afraid. @DusKing1 @asizon please check.

# dshot_telemetry_info
Dshot reads: 318044
Dshot invalid pkts: 318044
Dshot directionChange cycles: 0, micros: 0

Motor      eRPM      RPM      Hz   Invalid
=====   =======   ======   =====   =======
    0         0        0       0   NO DATA
    1         0        0       0   NO DATA
    2         0        0       0   NO DATA
    3         0        0       0   NO DATA

0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 

Also, BLHeli configurator isn't working very well with that build.

image

@asizon
Copy link
Member

asizon commented Dec 22, 2021

Doesnt work for mine with this hash

# dshot_telemetry_info
Dshot reads: 0
Dshot invalid pkts: 0
Dshot directionChange cycles: 0, micros: 0

Motor      eRPM      RPM      Hz   Invalid
=====   =======   ======   =====   =======
    0         0        0       0   NO DATA
    1         0        0       0   NO DATA
    2         0        0       0   NO DATA
    3         0        0       0   NO DATA

0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 

@asizon
Copy link
Member

asizon commented Dec 22, 2021

with last master i received dshot reads:

# dshot_telemetry_info
Dshot reads: 243967
Dshot invalid pkts: 243967
Dshot directionChange cycles: 0, micros: 0

Motor      eRPM      RPM      Hz   Invalid
=====   =======   ======   =====   =======
    0         0        0       0   NO DATA
    1         0        0       0   NO DATA
    2         0        0       0   NO DATA
    3         0        0       0   NO DATA

0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 

@asizon
Copy link
Member

asizon commented Dec 22, 2021

Definitelly it works as expected with last master. Dshot bidir works!Now i have flashed my airflet (v4?) with netronrcG4Aio target.

image

# dshot_telemetry_info
Dshot reads: 1091419
Dshot invalid pkts: 43159
Dshot directionChange cycles: 396, micros: 2

@asizon
Copy link
Member

asizon commented Dec 22, 2021

Then @DusKing1 you should check this config DMA resources :) and dont forget to use last Configurator dev build.

@DusKing1
Copy link
Contributor Author

@asizon no we are talking about a different target.

@DusKing1
Copy link
Contributor Author

@SteveCEvans I'm tracing back, will give you the hash later

@asizon
Copy link
Member

asizon commented Dec 23, 2021

@DusKing1 no hash meeded, master is working correctly, you should chech your target dma config or hardware for this board.

@DusKing1
Copy link
Contributor Author

DusKing1 commented Dec 23, 2021

@SteveCEvans how about this, the first version when we have the BMI270 driver code for all unified target. I did bunch of tests on this build. e0ad71db2b9fe9f561daed0345cd4f62ae5b8525

@SteveCEvans
Copy link
Member

@dusking I've tested with both current master and the build you reference above, and neither work with bit banged dshot.

With set dshot_bitbang = OFF the motor RPM is reported as expected. With set dshot_bitbang = ON there is no motor output whatsoever (as seen on a logic analyzer connected to the MOTOR 1 pin). Investigating.

@SteveCEvans
Copy link
Member

Bitbanged DSHOT doesn't work irrespective of bidirectional being used. The only difference is that the line sits low with is disabled, high with it enabled.

@SteveCEvans
Copy link
Member

@haslinghuis I'm reopening this as this is broken functionality and the unified target change is no more than a work around.

There's some clearly bogus code HERE which I'm investigating.

@daleckystepan
Copy link
Member

Should be fixed. Can you retest?

@DusKing1
Copy link
Contributor Author

@daleckystepan I'm a bit outdated here and what exact test I should be do?

@daleckystepan
Copy link
Member

@DusKing1 Probably testing dhsot and bi dshot on G4 target.

Question is if it works and if we can close this issue. Thank you.

@haslinghuis
Copy link
Member

Please check with latest firmware / configurator

@DusKing1
Copy link
Contributor Author

DusKing1 commented Apr 15, 2022

Ok I will try to arrange some tests for this, assign this to me please

@haslinghuis haslinghuis added this to Bug Tracker in Finalizing Firmware 4.3 Release via automation Apr 15, 2022
@DusKing1
Copy link
Contributor Author

DusKing1 commented Apr 19, 2022

Dshot works normally now.

But I found that OSD still have some problem. #11539

Finalizing Firmware 4.3 Release automation moved this from Bug Tracker to Finished (Merged) Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Bugs are excluded from automatically being marked as stale
Projects
No open projects
5 participants