Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DSHOT on G4 #11158

Closed
wants to merge 1 commit into from
Closed

Fix DSHOT on G4 #11158

wants to merge 1 commit into from

Conversation

SteveCEvans
Copy link
Member

Fixes: #11137

I suggest betaflight/unified-targets#545 be rolled back.

@DusKing1
Copy link
Contributor

ok, I'll arrange a test for this.

DusKing1
DusKing1 approved these changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@DusKing1 DusKing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK now this works for my case

@haslinghuis haslinghuis mentioned this pull request Dec 25, 2021
Merged
@asizon
Copy link
Member

asizon commented Dec 25, 2021

Works on NeutroRc G4 board/target:

# dshot_telemetry_info
Dshot reads: 208303
Dshot invalid pkts: 0
Dshot directionChange cycles: 401, micros: 2

@asizon
Copy link
Member

asizon commented Dec 25, 2021 •
edited

Im experimenting alotof dellay testing motors using motor tab using keyboard to increase decrease speed, seems related to timer based dshot.

@asizon
Copy link
Member

asizon commented Dec 25, 2021 •
edited

And this is using bitbang,also works but report 0 cycles and 0 micros:

# dshot_telemetry_info
Dshot reads: 90066
Dshot invalid pkts: 1
Dshot directionChange cycles: 0, micros: 0

@DusKing1
Copy link
Contributor

@asizon I guess the delay in your case was caused by high CPU loading. Try to overclock it and see what happens next.

@SteveCEvans any chance we can ease the CPU loading on G4?

@SteveCEvans
Copy link
Member Author

Dshot directionChange cycles: 401, micros: 2 reports the turnaround time in processor clock cycles, and us. This isn't used with bit-banged DSHOT which is why it's zero in that case.

@daleckystepan daleckystepan added this to the 4.3 milestone Dec 28, 2021
@daleckystepan daleckystepan added this to For discussion in Finalizing Firmware 4.3 Release via automation Dec 28, 2021
@haslinghuis haslinghuis moved this from For discussion to In Progress in Finalizing Firmware 4.3 Release Dec 29, 2021
@SteveCEvans SteveCEvans mentioned this pull request Dec 29, 2021
Merged
@SteveCEvans
Copy link
Member Author

Do not merge as will be included in #11198

@haslinghuis haslinghuis moved this from In Progress to Steve's PR in Mashup in Finalizing Firmware 4.3 Release Jan 4, 2022
@haslinghuis
Copy link
Member

Merged with #11198

@haslinghuis haslinghuis closed this Jan 7, 2022
Finalizing Firmware 4.3 Release automation moved this from Steve's PR in Mashup to Finished (Merged) Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@mathiasvr mathiasvr mathiasvr approved these changes

@DusKing1 DusKing1 DusKing1 approved these changes

@daleckystepan daleckystepan daleckystepan approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees
No one assigned
Labels
Don't Merge RN: BUGFIX
Projects
No open projects
Finalizing Firmware 4.3 Release
Finished (Merged)
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Dshot not working on latest master build on G4
8 participants
@SteveCEvans @DusKing1 @asizon @haslinghuis @limonspb @mathiasvr @daleckystepan @klutvott123