Adjust GYRO_LOCK_COUNT #11186
Closed
Adjust GYRO_LOCK_COUNT #11186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasvr
approved these changes
Dec 28, 2021
haslinghuis
approved these changes
Dec 28, 2021
|
Good find! |
klutvott123
approved these changes
Dec 28, 2021
daleckystepan
approved these changes
Dec 29, 2021
|
Do not merge as will be included in #11198 |
haslinghuis
added this to For discussion
in Finalizing Firmware 4.3 Release
via automation
haslinghuis
moved this from For discussion
to Steve's PR in Mashup
in Finalizing Firmware 4.3 Release
|
Merged with #11198 |
Finalizing Firmware 4.3 Release
automation
moved this from Steve's PR in Mashup
to Finished (Merged)
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skew between gyro interrupt and gyro loop is accumulated over
GYRO_LOCK_COUNTcycles and with the previous value, on an F411 with bit-banged DSHOT enabled, the effective gain created by this resulted in a failure to lock. Tested on F411, F405, F722 and H743