Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DARWINF4SX1280 target #11640

Closed
wants to merge 2 commits into from

Conversation

DMAXYANG
Copy link
Contributor

@DMAXYANG DMAXYANG commented Jun 7, 2022

Create DARWINF4SX1280 target Based on RC7, Attached is the test firmware
betaflight_4.3.0_DARWINF4SX1280.zip
1

@blckmn
Copy link
Member

blckmn commented Jun 7, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

We do not want to add any more non-unified targets. Use an unified target instead.

Reference; #11565

@haslinghuis haslinghuis closed this Jun 7, 2022
@SteveCEvans
Copy link
Member

@haslinghuis This is an SX1280 target and thus isn't supported by the STM32F411 target. Perhaps we should be adding an STM32F411SX1280 unified target?

@haslinghuis
Copy link
Member

haslinghuis commented Jun 7, 2022

Okay, it was denied for EMAX. A STM32F411SX1280 unified target sounds good, Then we can also convert BetaFPV, CrazyBee and maybe other targets as didn't check.

@haslinghuis haslinghuis reopened this Jun 7, 2022
@haslinghuis
Copy link
Member

@SteveCEvans there is no time anymore for a new target, Can you prepare please?
In the mean time should we accept this for 4.3

@SteveCEvans
Copy link
Member

I'm preparing a PR for an STM32F411SX1280 unified target.

@DMAXYANG
Copy link
Contributor Author

DMAXYANG commented Jun 8, 2022

@SteveCEvans Thank you, I will PR a unified target when you are done.

@SteveCEvans
Copy link
Member

Please see #11648 and betaflight/unified-targets#623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants