Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STM32F411SX1280 unified target #11648

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Add STM32F411SX1280 unified target #11648

merged 1 commit into from
Jun 14, 2022

Conversation

SteveCEvans
Copy link
Member

@SteveCEvans SteveCEvans commented Jun 12, 2022 •
edited
Loading

This adds unified target support for STM32F411 targets using the SX1280 SPI RX, such as the BETAFPVF4SX1280 and CRAZYBEEF4SX1280.

betaflight_4.3.0_STM32F411SX1280_6d17f3f.zip

See betaflight/unified-targets#623

@SteveCEvans SteveCEvans mentioned this pull request Jun 12, 2022
Merged
@SteveCEvans SteveCEvans added this to the 4.3 milestone Jun 12, 2022
@SteveCEvans SteveCEvans mentioned this pull request Jun 12, 2022
Closed
@blckmn
Copy link
Member

blckmn commented Jun 12, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

@betafpv-engineer betafpv-engineer mentioned this pull request Jun 13, 2022
Closed
@phobos-
Copy link
Contributor

phobos- commented Jun 13, 2022

Tested with CRAZYBEEF4SX1280 - works on the bench.

DusKing1
DusKing1 suggested changes Jun 13, 2022
View reviewed changes
src/main/target/STM32_UNIFIED/target.h
#define RX_EXPRESSLRS_TIMER_INSTANCE TIM5
#define RX_CHANNELS_AETR

#else // STM32F411SX1280
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-SX1280 normal STM32F411 target

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All targets except this one include support for other RC protocols.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-SX1280 normal unified target but yeah that's only a comment

src/main/target/STM32_UNIFIED/target.h
@@ -218,6 +241,40 @@
// to be supplied when the board is configured for the first time
#define USE_UNIFIED_TARGET

// Only enable ELRS support on STM32F411SX1280 target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if someday a vendor wanna make a SX1280 SPI FC based on other chip, for example F745?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has more than 512K of flash then SPI ELRS support will be included. If somebody makes an F722 FC with SPI ELRS then we’ll need to add an STMF7SX1280 target.

src/main/target/STM32_UNIFIED/target.h
@@ -78,6 +78,29 @@
#define TARGET_IO_PORTD 0xffff
#define TARGET_IO_PORTE 0xffff

#elif defined(STM32F411SX1280)
#define TARGET_BOARD_IDENTIFIER "S4SX"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S41S or S41X

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if any standard for the definition of these four character identifiers exists.

@haslinghuis haslinghuis modified the milestones: 4.3, 4.4 Jun 13, 2022
@betafpv-engineer
Copy link
Contributor

BETAFPVF4SX1280 found no problems.

@turboed13b
Copy link

Can you add iflightf411sx1280 to this?

@KarateBrot
Copy link
Member

KarateBrot commented Jun 14, 2022 •
edited
Loading

@turboed13b This is a unified target, so it is usable on all F411 boards with onboard sx1280.
The iFlight F411SX1280 now only needs a config file to apply the board defaults after flashing. You can add new config files by opening a PR in the unified-targets repo.

@SteveCEvans
Copy link
Member Author

@turboed13b If you have this FC, then please follow the instructions at https://github.com/betaflight/betaflight/blob/master/docs/TargetMaintenance/CreatingAUnifiedTarget.md. Use the image above as you do this. Then raise a PR to add the unified config as @KarateBrot requests above.

@XING-IF This would require your blessing.

@blckmn blckmn merged commit b6af12b into betaflight:master Jun 14, 2022
@GEME-Cyi
Copy link

@SteveCEvans Can you add icm42688P driver?

@KarateBrot
Copy link
Member

KarateBrot commented Jun 15, 2022 •
edited
Loading

@GEME-Cyi The ICM-42688-p is already supported in Betaflight

Edit: Misunderstanding, sorry. I didn't know that the f411 was excluded from using that gyro.

@SteveCEvans
Copy link
Member Author

See #11664

@haslinghuis haslinghuis modified the milestones: 4.4, 4.3.1 Jul 10, 2022
@haslinghuis haslinghuis mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusKing1 DusKing1 DusKing1 requested changes

@phobos- phobos- phobos- approved these changes

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@daleckystepan daleckystepan daleckystepan approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@SteveCEvans SteveCEvans

Labels
RN: NEW TARGET
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.
10 participants
@SteveCEvans @blckmn @phobos- @betafpv-engineer @turboed13b @KarateBrot @GEME-Cyi @haslinghuis @DusKing1 @daleckystepan