-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only write to FLASH once 64 bytes are buffered #11697
Conversation
AUTOMERGE: (FAIL)
|
@SteveCEvans It has been a preference to avoid boolean arguments in favor or two methods, one that behaves as though 'true' was specified, and one that behaves as if 'false' was specified. This leads to greater readability as you always have to look up what the 'true' or false does. A private (static) 'inner' method that uses a boolean argument is better, as the public api wouldn't contain the inner method. i.e. public:
private:
another preferred approach is to use an enum instead of the bool so that the argument is named.
|
Only write to FLASH once 64 bytes are buffered #11697 @SteveCEvans
…n_custom * commit '8d4f00532dfdd36467ed4b5f3395f5445b521dd6': Update version.h Fix compilation error when USE_RX_MSP_OVERRIDE is defined without USE_RX_MSP. Add STM32F411SX1280 unified target Add ICM42688P for all unified builds Make sure to write dshot stop cmd to all other motors when targeting less than max motor count Fix data overwriting in VCP_DataTx on F4 betaflight#11713 @daleckystepan Only write to FLASH once 64 bytes are buffered betaflight#11697 @SteveCEvans Backport Ghost jitter fix betaflight#11234 Fix Ghost RSSI values
Black box data to be written to FLASH is buffered in a 128 byte buffer, but is being written more often than necessary, typically 28 bytes at a time. This PR changes that to write no less than 64 bytes.
This reduces CPU load as fewer write operations are required.