New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G4 LPUART rework #11821
G4 LPUART rework #11821
Conversation
AUTOMERGE: (FAIL)
|
@haslinghuis both |
I'm waiting for the other PR to get merged before any fixes in this one anyway It fails for a different reason, looks like the file which includes and uses this Macro does not include |
Hi, would be great if this could be merged :) |
Besides rebase build is failing so needs some work after merge of #11786 G4 samples are on their way for development. |
269fb8c
to
606ba75
Compare
This comment has been minimized.
This comment has been minimized.
@DieHertz hope you don't mind. Have rebased this work and fixed the macro for non LPUART boards |
df557a9
to
e990ce8
Compare
This comment has been minimized.
This comment has been minimized.
|
e990ce8
to
3083184
Compare
This comment has been minimized.
This comment has been minimized.
3083184
to
05f58c1
Compare
This comment has been minimized.
This comment has been minimized.
05f58c1
to
dfa83ae
Compare
This comment has been minimized.
This comment has been minimized.
dfa83ae
to
abb7672
Compare
This comment has been minimized.
This comment has been minimized.
abb7672
to
34a8da9
Compare
Do you want to test this code? Here you have an automated build: |
For 4.4 we need: betaflight/unified-targets#989 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review in more details once #11786 is merged and this is rebased.
@@ -4931,6 +4931,10 @@ const cliResourceValue_t resourceTable[] = { | |||
#ifdef USE_INVERTER | |||
DEFA( OWNER_INVERTER, PG_SERIAL_PIN_CONFIG, serialPinConfig_t, ioTagInverter[0], SERIAL_PORT_MAX_INDEX ), | |||
#endif | |||
#if defined(USE_SOFTSERIAL1) || defined(USE_SOFTSERIAL2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #11786 (comment)
and this |
34a8da9
to
0eb07db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my new g4 airbot aio works good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my new g4 airbot aio works good
@KarateBrot @SteveCEvans please review #11786 |
Softserial users who upgrade firmware from versions before this PR, and who restore their previous settings by diff or preset->save/restore, will find that they lose soft serial. If soft serial was previously configured to serial TX 11, an older diff would include a line in the form:
Where After this PR, this line should be reverted with
And a line should be added, in the form:
but with the same pin designator as before, eg |
@ctzsnooze this has nothing to do with this PR. Rename was done in #12679 but only applies to config.h. Before that it was changed from SERIAL to UART. |
* Extracted SOTSERIAL_TX & RX resources * Fixed LPUART1 on G4
This PR contains changes from #11786 as it's somewhat related (touches the same places), I will remove them once it's merged.
Substantial changes are the ones related to UART DMA and IRQHandlers:
static uartDmaopt_t uartDmaopt[]
had no entry for LPUART1UARTDEV_CONFIG_MAX = 8
did not take neither UART10 nor LPUART1 into accountTested on my G4 board made by Airbot