Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Softserial #12679

Merged
merged 1 commit into from Apr 19, 2023
Merged

Fix Softserial #12679

merged 1 commit into from Apr 19, 2023

Conversation

haslinghuis
Copy link
Member

Also adds flash support to BETAFPVF4SX1280 board.

@haslinghuis haslinghuis added this to the 4.5 milestone Apr 15, 2023
@haslinghuis haslinghuis self-assigned this Apr 15, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Apr 15, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

nerdCopter commented Apr 16, 2023

flashed BETAFPVF4SX1280 and it saw resource SERIAL_TX 11 A08 proper.
mine does not have flash to test.

@haslinghuis haslinghuis force-pushed the fix-betafpvf4sx1280 branch 3 times, most recently from c544fd8 to 07f9d93 Compare April 16, 2023 22:32
@github-actions

This comment has been minimized.

@haslinghuis
Copy link
Member Author

Have two, one is a special build from betafpv with added flash. @asizon also has this very limited edition.
Put back two resources as they don't interfere

@ctzsnooze
Copy link
Member

Thanks, Mark @haslinghuis

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit 1fa4409 into betaflight:master Apr 19, 2023
19 checks passed
@haslinghuis haslinghuis deleted the fix-betafpvf4sx1280 branch April 19, 2023 15:38
AkankshaJjw pushed a commit to AkankshaJjw/betaflight that referenced this pull request May 29, 2023
@haslinghuis haslinghuis mentioned this pull request Jun 20, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants