Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source file re-arrangement for better separation of MCU types #12268

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 31, 2023

  • Move STM32 specific files to drivers/stm32

First of many PRs separating STM32 code from the main code base (so that we can introduce more MCUs in the future more easily).

- Move STM32 specific files to drivers/stm32
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn changed the title Source file re-arrangement for better spearation of MCU types Source file re-arrangement for better separation of MCU types Jan 31, 2023
@blckmn blckmn self-assigned this Jan 31, 2023
@blckmn blckmn added this to the 4.5 milestone Jan 31, 2023
@blckmn
Copy link
Member Author

blckmn commented Jan 31, 2023

I am of two minds... should we split the directories into stm32F4, f7, h7 etc or simply at32 and stm32.

I am inclined to go with the latter on the grounds there will be many more processors. We can always /drivers/stm32/f4/xx should the need arise.

@blckmn
Copy link
Member Author

blckmn commented Jan 31, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn requested a review from sugaarK January 31, 2023 23:13
@haslinghuis haslinghuis merged commit 33a96bb into betaflight:master Feb 1, 2023
@hydra
Copy link
Contributor

hydra commented Feb 1, 2023

guys, can we prioritise some of the older PR's, such as #11825, that didn't make it into 4.4 prior to reorganization changes such as this so that I and devs with other PR's don't have to continually rebase?

Continually rebasing is extremely inefficient, IMHO devs should either be working to get thier PR's in shape ready for merge or helping others do likewise before embarking on changes such as the one in this PR.

I feel a little bit more thought in planning the order of merges is required.

Also, this PR was created and merged really quickly and there's usually at least 24 hours before things are merged.

drivers/stm32/memprot_hal.c \
drivers/stm32/memprot_stm32h7xx.c \
drivers/stm32/sdio_h7xx.c \
drivers/stm32/bus_quadspi_hal.c \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication of line 291, included twice.

@hydra
Copy link
Contributor

hydra commented Feb 1, 2023

would suggest re-ordering all the source files in alphabetical order in each of the ****_SRC = \<files> assignments.

@blckmn blckmn deleted the stm32_intro branch February 1, 2023 18:07
@hydra
Copy link
Contributor

hydra commented Feb 3, 2023

I see my comments above were addressed in #12282 - thanks.

davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
…ight#12268)

Source file re-arrangement for better spearation of MCU types

- Move STM32 specific files to drivers/stm32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants