Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define USE_LATE_TASK_STATISTICS for AT32 #12328

Merged
merged 1 commit into from Feb 9, 2023

Conversation

SteveCEvans
Copy link
Member

AT32F435 has plenty of memory for this to be included.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member

blckmn commented Feb 8, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@KarateBrot
Copy link
Member

KarateBrot commented Feb 8, 2023

We could also add it here to be target specific and not platform specific:
https://github.com/betaflight/betaflight/blob/master/src/main/target/AT32F435/target.h#L74

I'm unsure what the better approach would be. Technically this should be a target specific define as there are AT32 chips with little memory for sure but on the other hand we could just #undef USE_LATE_TASK_STATISTICS in AT32 targets which don't have a lot of memory (if any of them would get ported to BF in the future).

@blckmn blckmn merged commit 01df7f3 into betaflight:master Feb 9, 2023
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants